Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added request-review workflow #2502

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Sep 27, 2024

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other: GitHub workflow

Description

Adds all the contributor to the icon you are changing as reviewers.

Before Submitting

@jguddas
Copy link
Member Author

jguddas commented Sep 27, 2024

Hmm, I think this might actually not work as intended, I can't add most people, even by hand.

@ericfennis
Copy link
Member

Hmm not sure if we want this. But I like the idea.

For old icons colebemis is listed as a contributor. Since he is not really involved in this project. Not sure if he should be invited.

@jguddas
Copy link
Member Author

jguddas commented Oct 1, 2024

Hmm not sure if we want this. But I like the idea.

For old icons colebemis is listed as a contributor. Since he is not really involved in this project. Not sure if he should be invited.

We could also mention them in the PR comment.

Another alternative is automatically generated code owners, not sure how that could work tho.

@ericfennis
Copy link
Member

Hmm no I think we can keep this idea. But we should add an if statement for colebemis username.

@jguddas
Copy link
Member Author

jguddas commented Oct 8, 2024

Hmm no I think we can keep this idea. But we should add an if statement for colebemis username.

I don't think he will get added by this workflow, I think it will ignore him

Hmm no I think we can keep this idea. But we should add an if statement for colebemis username.

It will not add him, I'm not sure what the requirements are, but this is the output I get:

gh pr edit 2502 --add-reviewer colebemis
'colebemis' not found

@ericfennis
Copy link
Member

@jguddas Thanks for checking! Maybe @karsa-mistmere wants to leave a review here as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants