fix(WPTestCase) add missing assertions, handle uploads removal

composer.json

@@ -60,7 +60,7 @@
     },
     "files": [
       "src/version-4-aliases.php",
-      "src/Deprecated/deprecated-functions.php",
+      "src/deprecated-functions.php",
       "src/functions.php"
     ]
   },

src/TestCase/WPTestCase.php

@@ -2,6 +2,7 @@
 
 namespace lucatume\WPBrowser\TestCase;
 
+use AllowDynamicProperties;
 use Codeception\Actor;
 use Codeception\Test\Unit;
 use lucatume\WPBrowser\Module\WPQueries;
@@ -10,10 +11,16 @@
 use ReflectionProperty;
 use WP_UnitTestCase;
 
+#[AllowDynamicProperties]
 class WPTestCase extends Unit
 {
     use WPTestCasePHPUnitMethodsTrait;
 
+    /**
+     * @var string[]|null
+     */
+    private array|null $coreTestCaseProperties = null;
+
     protected Actor $tester;
 
     // Backup, and reset, globals between tests.
@@ -232,11 +239,27 @@ protected function queries(): WPQueries
         return $wpQueries;
     }
 
+    private function isCoreTestCaseProperty(string $name): bool
+    {
+        if ($this->coreTestCaseProperties === null) {
+            $this->coreTestCaseProperties = array_map(
+                static fn(ReflectionProperty $p) => $p->getName(),
+                (new \ReflectionClass(self::getCoreTestCase()))->getProperties()
+            );
+        }
+
+        return in_array($name, $this->coreTestCaseProperties, true);
+    }
+
     /**
      * @throws ReflectionException
      */
     public function __get(string $name): mixed
     {
+        if (!$this->isCoreTestCaseProperty($name)) {
+            return $this->{$name} ?? null;
+        }
+
         $coreTestCase = self::getCoreTestCase();
         $reflectionProperty = new ReflectionProperty($coreTestCase, $name);
         $reflectionProperty->setAccessible(true);
@@ -248,6 +271,12 @@ public function __get(string $name): mixed
      */
     public function __set(string $name, mixed $value): void
     {
+        if (!$this->isCoreTestCaseProperty($name)) {
+            // Just set a dynamic property on the test case.
+            $this->{$name} = $value;
+            return;
+        }
+
         $coreTestCase = self::getCoreTestCase();
         $reflectionProperty = new ReflectionProperty($coreTestCase, $name);
         $reflectionProperty->setAccessible(true);
@@ -259,6 +288,10 @@ public function __set(string $name, mixed $value): void
      */
     public function __isset(string $name): bool
     {
+        if (!$this->isCoreTestCaseProperty($name)) {
+            return isset($this->{$name});
+        }
+
         $coreTestCase = self::getCoreTestCase();
         $reflectionProperty = new ReflectionProperty($coreTestCase, $name);
         $reflectionProperty->setAccessible(true);

src/TestCase/WPTestCasePHPUnitMethodsTrait.php

@@ -16,6 +16,15 @@ public static function setUpBeforeClass()
         protected function setUp()
         {
             parent::setUp();
+
+            // Restores the uploads directory if removed during tests.
+            $uploads = wp_upload_dir();
+            if (!is_dir($uploads['basedir'])
+                && !mkdir($uploads['basedir'], 0755, true)
+                && !is_dir($uploads['basedir'])) {
+                throw new \RuntimeException('Failed to create uploads base directory.');
+            }
+
             $this->set_up(); //@phpstan-ignore-line magic __call
             $this->backupAdditionalGlobals();
         }
@@ -46,6 +55,15 @@ public static function setUpBeforeClass(): void
         protected function setUp(): void
         {
             parent::setUp();
+
+            // Restores the uploads directory if removed during tests.
+            $uploads = wp_upload_dir();
+            if (!is_dir($uploads['basedir'])
+                && !mkdir($uploads['basedir'], 0755, true)
+                && !is_dir($uploads['basedir'])) {
+                throw new \RuntimeException('Failed to create uploads base directory.');
+            }
+
             $this->set_up(); //@phpstan-ignore-line magic __call
             $this->backupAdditionalGlobals();
         }

src/TestCase/WPUnitTestCasePolyfillsTrait.php

@@ -6,8 +6,19 @@
 
 trait WPUnitTestCasePolyfillsTrait
 {
-    protected function assertIsArray($actual, string $message = ''): void
+    /**
+     * @param array<mixed> $arguments
+     */
+    public function __call(string $name, array $arguments)
     {
-        TestCase::assertIsArray($actual, $message);
+        return TestCase::$name(...$arguments);
+    }
+
+    /**
+     * @param array<mixed> $arguments
+     */
+    public static function __callStatic(string $name, array $arguments)
+    {
+        return TestCase::$name(...$arguments);
     }
 }

tests/wploadersuite/DynamicPropertyTest.php

@@ -0,0 +1,39 @@
+<?php
+
+use lucatume\WPBrowser\TestCase\WPTestCase;
+
+/**
+ * Class DynamicPropertyTest.
+ *
+ * @since TBD
+ *
+ * @package wploadersuite;
+ */
+class DynamicPropertyTest extends WPTestCase
+{
+    /**
+     * It should allow setting and getting a dynamic property on the test case
+     *
+     * @test
+     */
+    public function should_allow_setting_and_getting_a_dynamic_property_on_the_test_case(): void
+    {
+        $this->assertFalse(isset($this->testDynamicProperty));
+        $this->assertNull($this->testDynamicProperty);
+
+        $this->testDynamicProperty = 23;
+
+        $this->assertTrue(isset($this->testDynamicProperty));
+        $this->assertEquals(23,$this->testDynamicProperty);
+
+        $this->testDynamicProperty = 89;
+
+        $this->assertTrue(isset($this->testDynamicProperty));
+        $this->assertEquals(89,$this->testDynamicProperty);
+
+        unset($this->testDynamicProperty);
+
+        $this->assertFalse(isset($this->testDynamicProperty));
+        $this->assertNull($this->testDynamicProperty);
+    }
+}