Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mesh-normal-vector benchmark array access #1514

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Fix mesh-normal-vector benchmark array access #1514

merged 1 commit into from
Nov 11, 2024

Commits on Nov 9, 2024

  1. Fix mesh-normal-vector benchmark array access 

    mesh-normal-scalar correctly fills sequential values in the output for
triangle cone function, but mesh-normal-vector accidentally reuses the
loop index, which results in writes to every third index of the array
(1, 4, etc.).

This is both slower (as the table turns into a hash map), and incorrect,
especially as we have a scalar version of the benchmark that does the
right thing.
    @zeux
    zeux committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    97b79ac View commit details
    Browse the repository at this point in the history