Remove noexcepts from Config (#1523)

Fixes #1515. By removing these `noexcept`s, we guarantee that the internal call to `std::swap` uses move semantics when a `Config` is copy-assigned.
luau-lang · Nov 12, 2024 · d1025d0 · d1025d0
1 parent 53e6e4b
commit d1025d0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/Config/include/Luau/Config.h b/Config/include/Luau/Config.h
@@ -21,10 +21,10 @@ constexpr const char* kConfigName = ".luaurc";
 struct Config
 {
     Config();
-    Config(const Config& other) noexcept;
-    Config& operator=(const Config& other) noexcept;
-    Config(Config&& other) noexcept = default;
-    Config& operator=(Config&& other) noexcept = default;
+    Config(const Config& other);
+    Config& operator=(const Config& other);
+    Config(Config&& other) = default;
+    Config& operator=(Config&& other) = default;
 
     Mode mode = Mode::Nonstrict;
 

diff --git a/Config/src/Config.cpp b/Config/src/Config.cpp
@@ -17,7 +17,7 @@ Config::Config()
     enabledLint.setDefaults();
 }
 
-Config::Config(const Config& other) noexcept
+Config::Config(const Config& other)
     : mode(other.mode)
     , parseOptions(other.parseOptions)
     , enabledLint(other.enabledLint)
@@ -40,7 +40,7 @@ Config::Config(const Config& other) noexcept
     }
 }
 
-Config& Config::operator=(const Config& other) noexcept
+Config& Config::operator=(const Config& other)
 {
     if (this != &other)
     {