Sync to upstream/release/618 (#1205)

# What's changed ### Debugger * Values after a 'continue' statement should not be accessible by debugger in the 'until' condition ### New Type Solver * Many fixes to crashes and hangs * Better bidirectional inference of table literal expressions ### Native Code Generation * Initial steps toward a shared code allocator --- ### Internal Contributors Co-authored-by: Aaron Weiss <[email protected]> Co-authored-by: Lily Brown <[email protected]> Co-authored-by: Vyacheslav Egorov <[email protected]>
luau-lang · Mar 22, 2024 · c1830d8 · c1830d8
1 parent d21b6fd
commit c1830d8
Show file tree

Hide file tree

Showing 51 changed files with 2,335 additions and 435 deletions.
diff --git a/Analysis/include/Luau/Constraint.h b/Analysis/include/Luau/Constraint.h
@@ -112,6 +112,7 @@ struct FunctionCheckConstraint
     TypePackId argsPack;
 
     class AstExprCall* callSite = nullptr;
+    NotNull<DenseHashMap<const AstExpr*, TypeId>> astTypes;
     NotNull<DenseHashMap<const AstExpr*, TypeId>> astExpectedTypes;
 };
 

diff --git a/Analysis/include/Luau/ConstraintSolver.h b/Analysis/include/Luau/ConstraintSolver.h
@@ -277,8 +277,12 @@ struct ConstraintSolver
      *
      * To determine which scope is appropriate, we also accept rootTy, which is
      * to be the type that contains blockedTy.
+     *
+     * A constraint is required and will validate that blockedTy is owned by this
+     * constraint. This prevents one constraint from interfering with another's
+     * blocked types.
      */
-    void bindBlockedType(TypeId blockedTy, TypeId resultTy, TypeId rootTy, Location location);
+    void bindBlockedType(TypeId blockedTy, TypeId resultTy, TypeId rootTy, NotNull<const Constraint> constraint);
 
     /**
      * Marks a constraint as being blocked on a type or type pack. The constraint

diff --git a/Analysis/include/Luau/Instantiation2.h b/Analysis/include/Luau/Instantiation2.h
@@ -61,6 +61,7 @@ struct Instantiation2 : Substitution
     {
     }
 
+    bool ignoreChildren(TypeId ty) override;
     bool isDirty(TypeId ty) override;
     bool isDirty(TypePackId tp) override;
     TypeId clean(TypeId ty) override;

diff --git a/Analysis/include/Luau/Set.h b/Analysis/include/Luau/Set.h
@@ -53,6 +53,17 @@ class Set
             insert(*it);
     }
 
+    void erase(T&& element)
+    {
+        bool& entry = mapping[element];
+
+        if (entry)
+        {
+            entry = false;
+            entryCount--;
+        }
+    }
+
     void erase(const T& element)
     {
         bool& entry = mapping[element];

diff --git a/Analysis/include/Luau/TableLiteralInference.h b/Analysis/include/Luau/TableLiteralInference.h
@@ -0,0 +1,28 @@
+// This file is part of the Luau programming language and is licensed under MIT License; see LICENSE.txt for details
+
+#pragma once
+
+#include "Luau/DenseHash.h"
+#include "Luau/NotNull.h"
+#include "Luau/TypeFwd.h"
+
+namespace Luau
+{
+
+struct TypeArena;
+struct BuiltinTypes;
+struct Unifier2;
+class AstExpr;
+
+TypeId matchLiteralType(
+    NotNull<DenseHashMap<const AstExpr*, TypeId>> astTypes,
+    NotNull<DenseHashMap<const AstExpr*, TypeId>> astExpectedTypes,
+    NotNull<BuiltinTypes> builtinTypes,
+    NotNull<TypeArena> arena,
+    NotNull<Unifier2> unifier,
+    TypeId expectedType,
+    TypeId exprType,
+    const AstExpr* expr
+);
+
+}
diff --git a/Analysis/include/Luau/Type.h b/Analysis/include/Luau/Type.h
@@ -146,6 +146,10 @@ struct BlockedType
     BlockedType();
     int index;
 
+    Constraint* getOwner() const;
+    void setOwner(Constraint* newOwner);
+
+private:
     // The constraint that is intended to unblock this type. Other constraints
     // should block on this constraint if present.
     Constraint* owner = nullptr;
@@ -419,6 +423,9 @@ struct Property
     TypeId type() const;
     void setType(TypeId ty);
 
+    // Sets the write type of this property to the read type.
+    void makeShared();
+
     bool isShared() const;
     bool isReadOnly() const;
     bool isWriteOnly() const;

diff --git a/Analysis/include/Luau/TypePack.h b/Analysis/include/Luau/TypePack.h
@@ -82,6 +82,8 @@ struct BlockedTypePack
     BlockedTypePack();
     size_t index;
 
+    struct Constraint* owner = nullptr;
+
     static size_t nextIndex;
 };