DM-46274: Fix filling of masked values in consolidated catalogs #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taranu
force-pushed
the
tickets/DM-46274
branch
from
840bce2
to
3493894
Compare
leeskelvin
reviewed
Sep 12, 2024
| @@ -408,14 +408,15 @@ def _make_multiband_catalog( | |||
| # Otherwise just stack the tables. | |||
| else: | |||
| multiband_catalog = vstack([multiband_catalog, catalog_next_band]) | |||
| # Fill any automatically masked values with NaNs. | |||
| # Fill any automatically masked values with NaNs if possible (float) | |||
| # Otherwise, use the dtype's minimum value (for int, bool, etc.) | |||
taranu
force-pushed
the
tickets/DM-46274
branch
from
3493894
to
95957b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fill fills in the entire array; this correctly only changes the masked values.