DM-40118: Produce more useful source injection data reduction logs #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
reviewed
Jul 19, 2023
| injection_catalogs = [Table(names=["ra", "dec", "source_type"])] | ||
| else: | ||
| raise RuntimeError( | ||
| "No injection catalogs overlapping this DatasetRef. Check your input catalog coverage." |
There was a problem hiding this comment.
The run() method does not refer to a DatasetRef does it? So I'm not convinced this error message should mention a DatasetRef.
There was a problem hiding this comment.
The injection_catalogs input comes from the inject_visit runQuantum, which is just a butlerQC.get(input_refs). If this returns nothing, then there is no overlap coverage for the query you've supplied. What would be more appropriate wording here? "...overlapping your data query" ?
There was a problem hiding this comment.
Changed to:
No injection sources overlap the data query. Check injection catalog coverage.
leeskelvin
force-pushed
the
tickets/DM-40118
branch
from
6cf07fb
to
d68ff0c
Compare
leeskelvin
changed the title
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.