Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tickets/PREOPS-4597: color by note in schedview prenight az/alt plt #52

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

ehneilsen
Copy link
Collaborator

Erik gave me a push on this this morning, so I pushed it to the top of my to do list.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (2e884a6) 12.32% compared to head (68b9965) 12.27%.

❗ Current head 68b9965 differs from pull request most recent head 780c473. Consider uploading reports for the commit 780c473 to get more accurate results

Files Patch % Lines
schedview/plot/nightly.py 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   12.32%   12.27%   -0.05%     
==========================================
  Files          39       39              
  Lines        3222     3234      +12     
  Branches      484      492       +8     
==========================================
  Hits          397      397              
- Misses       2816     2828      +12     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rhiannonlynne rhiannonlynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I could only test it with the sample_opsim.db outputs, not outputs from an auxtel setup.

@rhiannonlynne
Copy link
Member

sorry about the force push .. while I had your branch checked out, I accidentally pushed a commit here instead of to my branch-in-progress. So the force push was just removing that commit.

@ehneilsen ehneilsen merged commit 26b9c75 into main Nov 27, 2023
10 of 12 checks passed
@ehneilsen ehneilsen deleted the tickets/PREOPS-4597 branch November 27, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants