PREOPS-4518: Preserve wind and seeing conditions from a loaded pickle.

[alserene]

No description provided.

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (fd39cf9) 12.19% compared to head (1385421) 12.51%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   12.19%   12.51%   +0.32%     
==========================================
  Files          39       39              
  Lines        3156     3171      +15     
  Branches      477      477              
==========================================
+ Hits          385      397      +12     
- Misses       2762     2765       +3     
  Partials        9        9              

Files	Coverage Δ
tests/test_scheduler_dashboard.py	98.00% <100.00%> (+0.27%)	⬆️
...iew/app/scheduler_dashboard/scheduler_dashboard.py	0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ehneilsen]

Provided that update_conditions does not get called when a new pickle is loaded, this looks fine. (After a pickle is loaded but before the user sets a new time, the conditions instance that should be being used is the one from the pickle, not one generated by the dashboard's instance of ModelObservatory. I think that's what you've done, but I'm not 100% sure. One challenge with param is that it's sometimes hard to tell what triggers what.)

[ehneilsen]

In general, if code has previously been checked into git, just deleting it rather than commenting it is usually a better approach, although a text comment describing why one approach was taken rather than the other, maybe mentioning the commit where the other approach was taken, can be quite useful. Usually, "why" comments are more useful for posterity than "what" comments. (There are, of course, exceptions to this rule of thumb.)

(Just because I know this is good advice doesn't mean I actually always follow it myself, but I should.)

[alserene]

Yes, update_conditions only gets called when the date is changed 👍

The commented code is actually for the next ticket related to this, ticket 3817, allowing users to set weather conditions. (I realise now I've written the ticket number wrong.) I'll just remove the commented code and store in a file on my computer somewhere instead.

[emanehab99]

Looks good! Thanks for updating the tests