Update tests; consolidate pypi build and publish #46
Conversation
rhiannonlynne
force-pushed
the
tickets/PREOPS-4517
branch
from
4947726
to
04a1f81
Compare
|
Oh, that's interesting. It's running both the version of "run unit tests" from main and the version from here (the workflow yaml files for 'python_test' and 'test_and_build"). |
|
Wow, it is so weird how this repo has an issue with the ubuntu version of the download. Working on a thing to investigate. |
rhiannonlynne
force-pushed
the
tickets/PREOPS-4517
branch
from
155f7cb
to
9466a15
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
=======================================
Coverage 12.19% 12.19%
=======================================
Files 39 39
Lines 3156 3156
Branches 477 477
=======================================
Hits 385 385
Misses 2762 2762
Partials 9 9 ☔ View full report in Codecov by Sentry. |
| tar -xf skybrightness_pre_2023_09_19.tgz | ||
| echo "skybrightness_pre_2023_09_19.tgz complete" | ||
| export RUBIN_SIM_DATA_DIR=~/rubin_sim_data | ||
| rs_download_data --force --dirs scheduler,site_models,skybrightness_pre,throughputs,tests --tdqm_disable |
There was a problem hiding this comment.
Does this actually work here?
There was a problem hiding this comment.
Well ... I haven't fallen into the problem of needing to use it.
It did work from the cache download script.
This should only trigger if the version of rubin_sim changed since the cache was created. The cache will be re-created every night, or can be manually triggered.
So it's just a backup, really. We could copy in the full "download all these files individually", but it seems like not a great option. It could also be deleted entirely, which was my first thought .. and then I figured, no it was worth leaving in as a "good example".
It's also worth noting that the cache build script is currently running on an ubuntu runner, but it would be perfectly fine to move that to a macOS runner if needed.
There was a problem hiding this comment.
If you wanted me to pull the download individual files option into a different file, to preserve for easy pasting later, I could do that?
Reworking the workflows .. but I may need to merge this before being able to check, due to git mv for one of the workflows.