Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tickets/PREOPS-4400: Date does not update correctly. #44

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Tickets/PREOPS-4400: Date does not update correctly. #44

merged 5 commits into from
Nov 3, 2023

Conversation

alserene
Copy link
Collaborator

@alserene alserene commented Nov 2, 2023

  • Set date from the conditions object of a loaded pickle file.
  • Simplify date-related functions to manage pickle, url and widget date inputs.
  • Modify attribute names to remove confusion.

ehneilsen
ehneilsen approved these changes Nov 2, 2023
View reviewed changes
schedview/app/scheduler_dashboard/scheduler_dashboard.py Outdated

# Use instance of ModelObservatory until Conditions
# setting bug is fixed.
self._model_observatory = ModelObservatory(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If self._model_observatory already exists and has the correct nside, you should be able to just reuse it and avoid the significant time it takes to create a new instance.

@alserene alserene merged commit d4626da into main Nov 3, 2023
2 of 4 checks passed
@alserene alserene deleted the tickets/PREOPS-4400 branch November 3, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehneilsen ehneilsen ehneilsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alserene @ehneilsen