Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tickets/PREOPS-3845: make sample data for user testing of schedview #42

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

ehneilsen
Copy link
Collaborator

Running the notebook requires the version of rubin_sim on the tickets/PREOPS-4503, waiting to be merged until we figure out why checks aren't passing.

@rhiannonlynne
Copy link
Member

These changes look fine.
The notebook is intended to be instructions for anyone to create sample schedulers, I think? Would it make sense to specify the date that the scripts efd_sched.py and make_sample_scheduler.py should be run with if someone is trying to recreate some defaults?

@rhiannonlynne
Copy link
Member

Is there an action to fix the unit tests? It looks like the skybrightness_pre and survey start dates are out of sync here, which I wasn't expecting.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (08df27c) 12.19% compared to head (d2160e2) 12.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage   12.19%   12.19%           
=======================================
  Files          39       39           
  Lines        3156     3156           
  Branches      477      477           
=======================================
  Hits          385      385           
  Misses       2762     2762           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ehneilsen
Copy link
Collaborator Author

I have expanded the notebook to include the arguments needed to reconstruct the sample data rubin_sim sample and auxtel pickles in the example directory.
I updated the sky brightness file downloaded as part of getting the tests to pass for PREOPS-4125, and since rebaseing after merging that branch, this branch picks up that fix.

@ehneilsen ehneilsen merged commit 7b1101c into main Nov 3, 2023
6 checks passed
@rhiannonlynne rhiannonlynne deleted the tickets/PREOPS-3845 branch November 21, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants