Allow prenight data files to be set on command line even if arbitrary… #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… URLs are not allowed
rhiannonlynne
approved these changes
Oct 9, 2023
| if data_arg in kwargs: | ||
| specified_data_files[data_arg] = str(file_path) | ||
|
|
||
| prenight = RestrictedInputPrenight(data_dir=data_dir, **specified_data_files) |
There was a problem hiding this comment.
Oh interesting .. so I think this means that if you do not allow arbitrary data urls (which I thought meant uploading files only, rather than files from the filesystem), that you have to pre-specify which data directories should be allowed?
So the choices are -- data files from paths that are specified at startup vs. any data file + URL uploads?
(I'm not sure if that would be clear to other people, but wasn't clear to me, if that's how it works)
There was a problem hiding this comment.
Yes, that's right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… URLs are not allowed