DM-41049: Allow derived types in ConfigDictField items #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
==========================================
+ Coverage 85.37% 85.38% +0.01%
==========================================
Files 46 46
Lines 3631 3634 +3
==========================================
+ Hits 3100 3103 +3
Misses 531 531 ☔ View full report in Codecov by Sentry. |
natelust
reviewed
Jan 23, 2024
| @@ -76,7 +76,7 @@ def __setitem__(self, k, x, at=None, label="setitem", setHistory=True): | |||
| if x == dtype: | |||
| self._dict[k] = dtype(__name=name, __at=at, __label=label) | |||
| else: | |||
| self._dict[k] = dtype(__name=name, __at=at, __label=label, **x._storage) | |||
| self._dict[k] = x.__class__(__name=name, __at=at, __label=label, **x._storage) | |||
There was a problem hiding this comment.
Why did you use __class__ here instead of type?
There was a problem hiding this comment.
I can't remember having a good reason so I changed it to type.
taranu
force-pushed
the
tickets/DM-41049
branch
from
2495b1f
to
a2cdc06
Compare
taranu
force-pushed
the
tickets/DM-41049
branch
from
a2cdc06
to
ac50554
Compare
|
@natelust and @TallJimbo convinced me that supporting derived types in Config*Field would be too disruptive of a change, so I'm moving the useful parts from this ticket (updated tests, error messages, etc) to DM-43415. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changes