DM-47263: Simplify amp offset correction logging and config #358
+104
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeskelvin
force-pushed
the
tickets/DM-47263
branch
4 times, most recently
from
5410abc
to
d2e9a16
Compare
erykoff
approved these changes
Oct 31, 2024
python/lsst/ip/isr/ampOffset.py
Outdated
| ampsOffsets[ampId] += interfaceWeight * interfaceOffset | ||
| quartile_summary = np.percentile(interfaceOffsetOriginals, [0, 25, 50, 75, 100]) |
There was a problem hiding this comment.
I think you might need a check here to make sure numbers were measured or else this is going to crash on an empty input. (I don't know if it is possible, but I imagine it might be in the limit of one working amp?)
python/lsst/ip/isr/ampOffset.py
Outdated
| ID of the first amplifier. | ||
| ampIdB : int | ||
| ID of the second amplifier. | ||
| ampNameA : int |
There was a problem hiding this comment.
This is not an int anymore.
python/lsst/ip/isr/ampOffset.py
Outdated
| ID of the second amplifier. | ||
| ampNameA : int | ||
| Name of the first amplifier. | ||
| ampNameB : int |
leeskelvin
force-pushed
the
tickets/DM-47263
branch
from
d2e9a16
to
93981f9
Compare
leeskelvin
force-pushed
the
tickets/DM-47263
branch
from
93981f9
to
04dfba6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.