DM-46426: Create new IsrTaskLSST pipeline yaml for CTI #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Broughton
force-pushed
the
tickets/DM-46426
branch
from
c66de67
to
6c748ae
Compare
czwa
approved these changes
Oct 7, 2024
erykoff
reviewed
Oct 7, 2024
Alex-Broughton
force-pushed
the
tickets/DM-46426
branch
from
6c748ae
to
d300448
Compare
erykoff
reviewed
Oct 9, 2024
…nd standardize everything to electron
Alex-Broughton
force-pushed
the
tickets/DM-46426
branch
from
d300448
to
6a35667
Compare
erykoff
reviewed
Oct 9, 2024
Alex-Broughton
force-pushed
the
tickets/DM-46426
branch
2 times, most recently
from
43a7457
to
57d4a08
Compare
erykoff
reviewed
Oct 10, 2024
Alex-Broughton
force-pushed
the
tickets/DM-46426
branch
2 times, most recently
from
72070ae
to
6733c6f
Compare
erykoff
reviewed
Oct 10, 2024
python/lsst/ip/isr/isrTask.py
Outdated
| # The overscan statistics units will always match the units of | ||
| # the image at the point they are calculated. | ||
| metadata[f"{keyBase} SERIAL UNITS"] = metadata.get("LSST ISR UNITS") | ||
| metadata[f"{keyBase} PARALLEL UNITS"] = metadata.get("LSST ISR UNITS") |
There was a problem hiding this comment.
Should this be checking if serial/parallel overscan is turned on? Especially for cameras that don't have parallel overscan.
Alex-Broughton
force-pushed
the
tickets/DM-46426
branch
2 times, most recently
from
bf29ca2
to
615b3aa
Compare
Alex-Broughton
force-pushed
the
tickets/DM-46426
branch
from
615b3aa
to
a1d8f9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.