Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-45325: Add realistic LSSTCam CTI to IsrMockLSST and IsrTaskLSST and tests #341

Merged
merged 6 commits into from
Sep 24, 2024
Merged

DM-45325: Add realistic LSSTCam CTI to IsrMockLSST and IsrTaskLSST and tests #341

merged 6 commits into from
Sep 24, 2024

Conversation

Alex-Broughton
Copy link
Contributor

No description provided.

erykoff
erykoff reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions on provenance and choices made in the test processing. Also I'm surprised that the calls in isrTaskLSST worked with no modification (!).

python/lsst/ip/isr/isrMock.py Outdated Show resolved Hide resolved
python/lsst/ip/isr/isrMockLSST.py Outdated Show resolved Hide resolved
tests/test_isrTaskLSST.py Outdated Show resolved Hide resolved
tests/test_isrTaskLSST.py Outdated Show resolved Hide resolved
tests/test_isrTaskLSST.py Outdated Show resolved Hide resolved
erykoff
erykoff reviewed Aug 23, 2024
View reviewed changes
tests/test_isrTaskLSST.py Outdated Show resolved Hide resolved
@Alex-Broughton Alex-Broughton force-pushed the tickets/DM-45325 branch 2 times, most recently from db0f322 to 688f925 Compare August 27, 2024 17:53
erykoff
erykoff requested changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several formatting comments and a few questions on the odd pixels.

python/lsst/ip/isr/deferredCharge.py Show resolved Hide resolved
python/lsst/ip/isr/deferredCharge.py Show resolved Hide resolved
python/lsst/ip/isr/deferredCharge.py Show resolved Hide resolved
python/lsst/ip/isr/deferredCharge.py Show resolved Hide resolved
python/lsst/ip/isr/deferredCharge.py Show resolved Hide resolved
python/lsst/ip/isr/isrMockLSST.py Outdated Show resolved Hide resolved
python/lsst/ip/isr/isrMockLSST.py Outdated Show resolved Hide resolved
python/lsst/ip/isr/isrMock.py Show resolved Hide resolved
tests/test_isrTaskLSST.py Outdated Show resolved Hide resolved
tests/test_isrTaskLSST.py Outdated Show resolved Hide resolved
@Alex-Broughton Alex-Broughton force-pushed the tickets/DM-45325 branch 2 times, most recently from c14868b to b8f139f Compare September 17, 2024 17:02
@Alex-Broughton Alex-Broughton force-pushed the tickets/DM-45325 branch 2 times, most recently from 039cf49 to 2fb8931 Compare September 19, 2024 21:28
erykoff
erykoff reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a first batch of comments.

python/lsst/ip/isr/deferredCharge.py Outdated Show resolved Hide resolved
python/lsst/ip/isr/deferredCharge.py Outdated Show resolved Hide resolved
python/lsst/ip/isr/deferredCharge.py Show resolved Hide resolved
python/lsst/ip/isr/isrMock.py Show resolved Hide resolved
python/lsst/ip/isr/isrMock.py Show resolved Hide resolved
@Alex-Broughton Alex-Broughton force-pushed the tickets/DM-45325 branch 2 times, most recently from 4dbea41 to 0ebf2e3 Compare September 20, 2024 15:59
erykoff
erykoff requested changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a specific test that the deferred charge is specifically doing what we want, or is it just "we still get back close to the truth and therefore everything is fine"?

python/lsst/ip/isr/isrMockLSST.py Outdated Show resolved Hide resolved
python/lsst/ip/isr/isrMockLSST.py Outdated Show resolved Hide resolved
python/lsst/ip/isr/isrMockLSST.py Outdated Show resolved Hide resolved
python/lsst/ip/isr/isrMockLSST.py Outdated Show resolved Hide resolved
python/lsst/ip/isr/isrMockLSST.py Outdated Show resolved Hide resolved
python/lsst/ip/isr/isrTaskLSST.py Outdated Show resolved Hide resolved
tests/test_isrTask.py Outdated Show resolved Hide resolved
tests/test_isrTaskLSST.py Outdated Show resolved Hide resolved
erykoff
erykoff requested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor doc comments but a major problem that you cannot override a config in a task in a pipeline. This will crash outside of unit tests.

python/lsst/ip/isr/isrMock.py Show resolved Hide resolved
python/lsst/ip/isr/isrMock.py Show resolved Hide resolved
python/lsst/ip/isr/isrTaskLSST.py Outdated Show resolved Hide resolved
@Alex-Broughton Alex-Broughton force-pushed the tickets/DM-45325 branch 2 times, most recently from 5c3732f to cdc52fe Compare September 24, 2024 17:58
@Alex-Broughton Alex-Broughton merged commit dde0937 into main Sep 24, 2024
2 checks passed
@Alex-Broughton Alex-Broughton deleted the tickets/DM-45325 branch September 24, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erykoff erykoff erykoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alex-Broughton @erykoff