Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-40094 Convolution control edge copy method results in diverging correction in fluxConservingBrighterFatterCorrection #276

Merged
merged 2 commits into from
Aug 30, 2023
Merged

DM-40094 Convolution control edge copy method results in diverging correction in fluxConservingBrighterFatterCorrection #276

merged 2 commits into from
Aug 30, 2023

Conversation

czwa
Copy link
Contributor

@czwa czwa commented Jul 19, 2023

I've also folded in the change from youtsumi:u/youtsumi/DM-40049 to fix the max iteration log message.

@czwa czwa requested a review from erykoff July 19, 2023 21:40
erykoff
erykoff approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish these things were tested...

@czwa czwa merged commit 7f3caa1 into main Aug 30, 2023
2 checks passed
@czwa czwa deleted the tickets/DM-40094 branch August 30, 2023 19:45
@youtsumi youtsumi mentioned this pull request Jan 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erykoff erykoff erykoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czwa @erykoff