DM-38776: Generalize amp-to-amp offset correction task #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enourbakhsh
force-pushed
the
tickets/DM-38776
branch
2 times, most recently
from
72a695d
to
4fec803
Compare
enourbakhsh
force-pushed
the
tickets/DM-38776
branch
8 times, most recently
from
cb146e4
to
98a86e2
Compare
enourbakhsh
force-pushed
the
tickets/DM-38776
branch
from
98a86e2
to
35ad026
Compare
leeskelvin
reviewed
Aug 1, 2023
leeskelvin
reviewed
Aug 1, 2023
leeskelvin
reviewed
Aug 1, 2023
leeskelvin
reviewed
Aug 1, 2023
leeskelvin
reviewed
Aug 1, 2023
leeskelvin
reviewed
Aug 1, 2023
leeskelvin
reviewed
Aug 1, 2023
leeskelvin
reviewed
Aug 1, 2023
leeskelvin
reviewed
Aug 1, 2023
leeskelvin
reviewed
Aug 1, 2023
enourbakhsh
force-pushed
the
tickets/DM-38776
branch
6 times, most recently
from
67356b2
to
8dbd490
Compare
czwa
reviewed
Aug 2, 2023
enourbakhsh
force-pushed
the
tickets/DM-38776
branch
6 times, most recently
from
2e1c7b7
to
299615a
Compare
czwa
requested changes
Aug 4, 2023
enourbakhsh
force-pushed
the
tickets/DM-38776
branch
2 times, most recently
from
baed1a8
to
991b08c
Compare
czwa
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
I think I'm happy now. The scatter (sigma) in the test values is higher than I would have thought, but it's possible that's an indication that edge-length weighting is needed. Looking into that is out-of-scope for this ticket, but I think it's worth adding a new ticket to do that work.
enourbakhsh
force-pushed
the
tickets/DM-38776
branch
6 times, most recently
from
67d5f21
to
708d3d1
Compare
enourbakhsh
force-pushed
the
tickets/DM-38776
branch
from
708d3d1
to
3adcf35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.