DM-47368: Restrict when subtractImages sources selector raises #350
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Nov 4, 2024
| @@ -822,7 +822,8 @@ def _sourceSelector(self, sources, mask): | |||
| self.log.error("Too few sources to calculate the PSF matching kernel: " | |||
| "%i selected but %i needed for the calculation.", | |||
| len(selectSources), self.config.minKernelSources) | |||
| raise RuntimeError("Cannot compute PSF matching kernel: too few sources selected.") | |||
| if ~self.config.allowKernelSourceDetection: | |||
There was a problem hiding this comment.
Suggested change
| if ~self.config.allowKernelSourceDetection: | |
| if not self.config.allowKernelSourceDetection: |
isullivan
force-pushed
the
tickets/DM-47368
branch
from
c4c4304
to
540c42c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not raise an error in source selection if allowKernelSourceDetection=True