Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-45318: Add NO_DATA to detectAndMeasure's excludeMaskPlanes #345

Merged
merged 2 commits into from
Oct 30, 2024
Merged

DM-45318: Add NO_DATA to detectAndMeasure's excludeMaskPlanes #345

merged 2 commits into from
Oct 30, 2024

Conversation

mrawls
Copy link
Contributor

@mrawls mrawls commented Oct 22, 2024

This PR adds NO_DATA to the list of masks to ignore when detecting sources in difference images alongside EDGE, SAT, BAD, and INTRP.

@mrawls mrawls requested a review from abudlong October 22, 2024 00:07
@mrawls
Copy link
Contributor Author

mrawls commented Oct 24, 2024

Plot twist, turns out the meas_algorithms change broke testDipoleEdge, which is designed to test that dipoles close to image edges are not detected. It makes sense that some of these should now be detected if they are close to the edge but (presumably) not super close to the edge, so I'll see if I can fine-tune the test dipole coordinates to be more in the "super close" regime, unless @isullivan has a better suggestion.

@mrawls mrawls merged commit ebdfc2c into main Oct 30, 2024
2 checks passed
@mrawls mrawls deleted the tickets/DM-45318 branch October 30, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abudlong abudlong abudlong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrawls @abudlong