-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-45263: Add new tap_schema module #90
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyMcCormick
force-pushed
the
tickets/DM-45263
branch
2 times, most recently
from
July 18, 2024 23:49
626f499
to
fd25d5a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 91.54% 92.02% +0.48%
==========================================
Files 16 20 +4
Lines 1881 2534 +653
Branches 410 519 +109
==========================================
+ Hits 1722 2332 +610
- Misses 86 120 +34
- Partials 73 82 +9 ☔ View full report in Codecov by Sentry. |
JeremyMcCormick
force-pushed
the
tickets/DM-45263
branch
5 times, most recently
from
July 19, 2024 01:16
3bc98e3
to
fe43632
Compare
JeremyMcCormick
changed the title
DM-45263: Add new module for managing TAP_SCHEMA
DM-45263: Add new tap_schema module
Jul 19, 2024
JeremyMcCormick
force-pushed
the
tickets/DM-45263
branch
from
July 19, 2024 02:31
fe43632
to
c411808
Compare
JeremyMcCormick
force-pushed
the
tickets/DM-45263
branch
8 times, most recently
from
August 21, 2024 20:05
12e6c6e
to
d50ab43
Compare
JeremyMcCormick
force-pushed
the
tickets/DM-45263
branch
5 times, most recently
from
August 21, 2024 22:19
fda50b2
to
8b3334f
Compare
JeremyMcCormick
force-pushed
the
tickets/DM-45263
branch
6 times, most recently
from
August 29, 2024 20:46
672bd5f
to
baed0d4
Compare
This makes internal YAML files available as resources when using ResourcePath from lsst-resources.
JeremyMcCormick
force-pushed
the
tickets/DM-45263
branch
5 times, most recently
from
October 4, 2024 16:50
2e978e7
to
54fab96
Compare
Implement loading of Felis schema data into TAP_SCHEMA using new TableManager and DataLoader classes. Initialization of the TAP_SCHEMA database is not supported directly but can be done using the standard 'felis create' command using the appropriate schema file which defines a compatible database.
This Felis file defines a TAP_SCHEMA database with nonstandard names for the tables, postfixed with "11", and an alternate name for the schema itself of "tap_schema11". These alternate names are used to test functionality of the tap_schema TableManager class.
Use testing.postgresql to setup a temporary database for testing the functionality of the tap_schema module.
Several of these checks have been put into the data model instead and should not be necessary to repeat here.
JeremyMcCormick
force-pushed
the
tickets/DM-45263
branch
from
October 4, 2024 19:43
54fab96
to
d49165d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides the initial implementation for a
tap_schema
module, eventually intended to deprecate and replace the functionality of the Felistap
module. It provides the newload-tap-schema
command in the Felis CLI, which uses the new module to update a TAP_SCHEMA database. The internal representation of TAP_SCHEMA was changed to use a Felis file, found in thefelis.schemas
package.Additional Changes
felis.datamodel.Schema
for looking up objectsSchema
from a file orlsst.resources.ResourcePath
lsst-resources
to project requirementstest.utils
module with some useful test utility functionsfelis.schemas
package, which currently includes a standard TAP_SCHEMA representationRelatively complete test coverageis provided for the new module. Some functions marked as not covered actually are tested from loading schema files from
tests/data
. Thetap
module, which this is designed to replace, remains minimally covered in testing.No breaking changes were intended to be introduced to the API or the CLI by this update. The
felis load-tap
andinit-tap
commands should still work exactly the same as before and can be used side-by-side with the new module for comparison.