Fix bugs in how size and arraysize were being handled #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix obvious bug where wrong arraysize variable was being used in setting size. Do not set arraysize automatically for fields with length of 1.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
+ Coverage 91.01% 91.49% +0.47%
==========================================
Files 16 16
Lines 1881 1881
Branches 410 410
==========================================
+ Hits 1712 1721 +9
+ Misses 96 86 -10
- Partials 73 74 +1 ☔ View full report in Codecov by Sentry. |
stvoutsin
approved these changes
Sep 26, 2024
| @@ -407,7 +407,9 @@ def visit_column(self, column_obj: datamodel.Column, table_obj: Table) -> Tap11B | |||
| felis_type = FelisType.felis_type(felis_datatype.value) | |||
| column.datatype = column_obj.votable_datatype or felis_type.votable_name | |||
|
|
|||
| column.arraysize = column_obj.votable_arraysize or column_obj.length | |||
| column.arraysize = column_obj.votable_arraysize or ( | |||
| column_obj.length if (column_obj.length is not None and column_obj.length > 1) else None | |||
There was a problem hiding this comment.
Is there a case where column_obj.votable_arraysize is None column_obj_length == 1 and we want column.arraysize set to that?
There was a problem hiding this comment.
It says in the TAP 1.1 spec that arraysize should never be set to 1 but should be null instead in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix obvious bug where wrong arraysize variable was being used in setting size.
Do not set arraysize automatically for fields with length of 1.
Checklist
docs/changes