DM-45938: Add support for generating IDs on data model objects #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
+ Coverage 90.74% 90.92% +0.18%
==========================================
Files 16 16
Lines 1805 1885 +80
Branches 386 417 +31
==========================================
+ Hits 1638 1714 +76
+ Misses 101 97 -4
- Partials 66 74 +8 ☔ View full report in Codecov by Sentry. |
JeremyMcCormick
force-pushed
the
tickets/DM-45938
branch
6 times, most recently
from
e7285e1
to
22c03e3
Compare
gpdf
requested changes
Aug 26, 2024
Implement a pre-validator which creates object IDs where they are missing on Schema objects. The values of the generated IDs for schema, table and column objects are constructed based on the common usage patterns from SDM Schemas. Constraints and indexes use the name field as the ID. The `--id-generation` flag must be used from the command-line to enable this feature, as it is off by default.
Add a top-level flag for enabling ID generation and pass it to the other commands via the Click context.
Load a schema without IDs and set them, and load the same schema with ID generation turned off to check that an exception is thrown.
JeremyMcCormick
force-pushed
the
tickets/DM-45938
branch
from
22c03e3
to
0da628c
Compare
gpdf
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
--id-generationflag which turns on generation of@idvalues for schema objects that do not have them.Add a Schema validator that checks if index names are unique.