DM-47143: Allow entry points to be used to discover cli plugins #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-47143
branch
2 times, most recently
from
938c68f
to
4a0ea6f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1107 +/- ##
==========================================
- Coverage 89.47% 89.46% -0.02%
==========================================
Files 361 361
Lines 47741 47787 +46
Branches 5794 5799 +5
==========================================
+ Hits 42717 42752 +35
- Misses 3640 3649 +9
- Partials 1384 1386 +2 ☔ View full report in Codecov by Sentry. |
This lets you know which plugins are costing the most start up time (the answer is ingest-photodiode)
Otherwise it is called once to get the commands and then once again for every single subcommand for `butler -h`. Adding a cache shaves a second off `butler -h` runtime.
timj
force-pushed
the
tickets/DM-47143
branch
from
4a0ea6f
to
80b168e
Compare
This was referenced Oct 28, 2024
andy-slac
approved these changes
Oct 29, 2024
This is in addition to the environment variable. The plugins return the actual commands rather than any links to YAML files.
timj
force-pushed
the
tickets/DM-47143
branch
from
80b168e
to
5f3629d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changesconfigs/old_dimensions