Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #1095 from lsst/tickets/DM-46799" #1101

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented Oct 17, 2024

This reverts commit 4ff6cc6, reversing changes made to 3abf212.

Various Jenkins ci_cpp runs are at least strongly suggesting that this ticket broke something to do with isCalibration consistency in dataset type registration and/or fetches.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

This reverts commit 4ff6cc6, reversing
changes made to 3abf212.
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 89.36877% with 64 lines in your changes missing coverage. Please review.

Project coverage is 89.74%. Comparing base (588e17a) to head (fd37c27).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../butler/registry/datasets/byDimensions/_storage.py 91.57% 16 Missing and 14 partials ⚠️
python/lsst/daf/butler/registry/sql_registry.py 67.44% 9 Missing and 5 partials ⚠️
.../butler/registry/datasets/byDimensions/_manager.py 88.34% 7 Missing and 5 partials ⚠️
...on/lsst/daf/butler/registry/_dataset_type_cache.py 71.42% 3 Missing and 1 partial ⚠️
python/lsst/daf/butler/registry/managers.py 33.33% 1 Missing and 1 partial ⚠️
.../daf/butler/registry/queries/_sql_query_backend.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1101      +/-   ##
==========================================
+ Coverage   89.70%   89.74%   +0.04%     
==========================================
  Files         360      361       +1     
  Lines       47411    47410       -1     
  Branches     5731     5724       -7     
==========================================
+ Hits        42529    42549      +20     
+ Misses       3520     3508      -12     
+ Partials     1362     1353       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TallJimbo TallJimbo merged commit be031d3 into main Oct 17, 2024
17 of 18 checks passed
@TallJimbo TallJimbo deleted the u/jbosch/DM-46799/revert branch October 17, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant