Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing in cliLogTestBase. #1097

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Fix typing in cliLogTestBase. #1097

merged 1 commit into from
Oct 15, 2024

Conversation

dhirving
Copy link
Contributor

@dhirving dhirving commented Oct 14, 2024

Cherry-pick Jim's fix for the latest mypy breakage to main, since it's needed on other branches.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

I think breakage was spurred by a newer stricter MyPy.
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.73%. Comparing base (86eadf3) to head (4a9cb03).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
python/lsst/daf/butler/tests/cliLogTestBase.py 44.44% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1097      +/-   ##
==========================================
- Coverage   89.73%   89.73%   -0.01%     
==========================================
  Files         361      361              
  Lines       47319    47324       +5     
  Branches     5767     5709      -58     
==========================================
+ Hits        42462    42466       +4     
- Misses       3502     3506       +4     
+ Partials     1355     1352       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhirving dhirving marked this pull request as ready for review October 15, 2024 16:29
@dhirving dhirving merged commit 6616209 into main Oct 15, 2024
17 of 18 checks passed
@dhirving dhirving deleted the u/dhirving/fix-mypy-breakage branch October 15, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants