Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-46563: Use masked record arrays in arrow to numpy conversion #1087

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

timj
Copy link
Member

@timj timj commented Sep 30, 2024

This is #1086 with the right branch name.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with test, but a question about the typing.

python/lsst/daf/butler/formatters/parquet.py Show resolved Hide resolved
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.69%. Comparing base (ca923c0) to head (9ea85bc).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1087   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files         360      360           
  Lines       47094    47110   +16     
  Branches     9693     9696    +3     
=======================================
+ Hits        42240    42256   +16     
  Misses       3480     3480           
  Partials     1374     1374           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timj timj merged commit 799fa7f into main Oct 1, 2024
18 checks passed
@timj timj deleted the tickets/DM-46563 branch October 1, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants