DM-46363: Inject SqlQueryContext into ObsCoreManager at top level #1081
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the ExposureRegionFactory interface to no longer expose SqlQueryContext outside daf_butler.
The ExposureRegionFactory interface has one internal implementation and one external implementation in the dax_obscore package. The internal implementation needs privileged access to SqlRegistry internals, but the external one does not. The external one now needs to support RemoteButler and can no longer provide a SqlRegistry object.
In order to make this change, the SqlQueryContext is now created once when ObscoreLiveTableManager is created and passed to the internal ExposureRegionFactory's constructor, instead of being part of the ExposureRegionFactory method call interface.
Checklist
doc/changes
configs/old_dimensions