DM-46340: Fix query datasets failing when run collection specified #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhirving
force-pushed
the
tickets/DM-46340
branch
from
ff806b0
to
13da234
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1079 +/- ##
=======================================
Coverage 89.69% 89.69%
=======================================
Files 360 360
Lines 47041 47054 +13
Branches 9659 9660 +1
=======================================
+ Hits 42193 42206 +13
Misses 3480 3480
Partials 1368 1368 ☔ View full report in Codecov by Sentry. |
dhirving
force-pushed
the
tickets/DM-46340
branch
from
1d5ca5a
to
14d0e7d
Compare
TallJimbo
approved these changes
Sep 16, 2024
Fix an issue where query_datasets would fail on Postgres 16 with the error 'psycopg2.errors.DatatypeMismatch: could not determine polymorphic type because input has type unknown'. This was occurring because a run collection name string literal was appearing in an any_value aggregate function without a type defined.
Fix an issue similar to the previous commit, where query_datasets would fail on Postgres 16 with the error 'psycopg2.errors.DatatypeMismatch: could not determine polymorphic type because input has type unknown'. This was occurring when there was a single collection specified for the dataset search, causing a literal "collection" dataset field value to be included in an any_value aggregate function.
dhirving
force-pushed
the
tickets/DM-46340
branch
from
8fa0c84
to
1582b9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/changesconfigs/old_dimensions