DM-43157: new query interfaces for dataset types and datasets of multiple types #1062
Conversation
TallJimbo
force-pushed
the
tickets/DM-43157
branch
2 times, most recently
from
6d1163b
to
174b8fa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1062 +/- ##
==========================================
+ Coverage 89.37% 89.38% +0.01%
==========================================
Files 362 365 +3
Lines 48288 48339 +51
Branches 5872 5872
==========================================
+ Hits 43155 43206 +51
Misses 3718 3718
Partials 1415 1415 ☔ View full report in Codecov by Sentry. |
TallJimbo
force-pushed
the
tickets/DM-43157
branch
2 times, most recently
from
5396bb0
to
783f3ee
Compare
| """Methods for working with the dataset types known to the Butler.""" | ||
|
|
||
| @abstractmethod | ||
| def get(self, name: str) -> DatasetType: |
There was a problem hiding this comment.
Are we going to immediately deprecate butler.get_dataset_type and move to butler.dataset_type.get() ?
There was a problem hiding this comment.
I think that'd be best, yes, if we all like butler.dataset_types more generally.
| # - 'where' exists on other result objects because the way they are | ||
| # constructed adds context (a dataset search join, some dimensions) that | ||
| # can help interpret arguments to 'where'. That's not generally true | ||
| # here, so calling `Query.where(...).all_datasets()` can do anything that | ||
| # `Query.all_datasets().where(...)` might be able to do. |
There was a problem hiding this comment.
We might want to have where just for consistency.
| # - 'order_by' and 'limit' are hard to implement in the common case where | ||
| # we have to run one query for each dimension group. |
There was a problem hiding this comment.
I think limit is probably desirable since these queries can easily return huge numbers of results. Should be relatively straightforward to implement if we're executing the queries serially -- you just start with the original limit and subtract from it for each subsequent query.
andy-slac
force-pushed
the
tickets/DM-43157
branch
from
783f3ee
to
303ba19
Compare
|
Rebased to current main. |
andy-slac
force-pushed
the
tickets/DM-43157
branch
2 times, most recently
from
f0a0cbf
to
7e5ed85
Compare
timj
force-pushed
the
tickets/DM-43157
branch
from
7e5ed85
to
8bac470
Compare
Checklist
doc/changesconfigs/old_dimensions