DM-46358: Add new IsrTaskLSST calibration pipelines for LSSTCam. #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
approved these changes
Oct 21, 2024
| @@ -1,4 +1,4 @@ | |||
| description: cp_pipe FLAT calibration construction | |||
| description: cp_pipe LSSTCam FLAT calibration construction, optimized for a single chip. | |||
There was a problem hiding this comment.
This file can probably be dropped, as we're unlikely to need it for the full camera.
There was a problem hiding this comment.
I assumed we wanted these in case somebody wanted to run a test flat for a single chip. If that's wrong I can remove them all.
| linearityType: Spline | ||
| usePhotodiode: true | ||
| splineGroupingColumn: CCOBCURR | ||
| maxLinearAdu: 120000 |
There was a problem hiding this comment.
Is this parameter no longer needed? It seems to be gone in the new pipelines, and I just wanted to check that was intentional. Apologies if I didn't follow the inheritance correctly and just missed it. I think the rest of the configs are consistent.
erykoff
force-pushed
the
tickets/DM-46358
branch
from
27de39b
to
74ac812
Compare
erykoff
force-pushed
the
tickets/DM-46358
branch
from
7fa6d97
to
a0b7bca
Compare
This also fixes an index error in the selection of the max in the case of intermediate bad points.
erykoff
force-pushed
the
tickets/DM-46358
branch
from
a0b7bca
to
74a8894
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some code change on this ticket as well to better handle outliers on the initial linearity turnoff fit that came up with full camera testing.