Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for custom DB port (default is also set) #563

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lospejos
Copy link

@lospejos lospejos commented Mar 3, 2021

Added support for custom DB port (default is also set)

@AlexKirkouski
Copy link
Contributor

Pretty good pull request. However the thing is that, as far as I understand, it is assumed that port is set as a part of host (for example localhost:3456). Maybe it makes sense sometimes to distinguish them, but so far it's not evident. However we'll think about merging this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants