Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the CMake file hard-configured a static build of enet. These are the minimal changes required to enable shared builds of enet as well.
CMake has the default BUILD_SHARED_LIBS option to determinate if a shared or static build is desired.
For builds that
the following two definitions are declared:
ENET_DLL
(see documentation)ENET_BUILDING_LIB
Why only for MSVC and Clang? Because enet then makes use of
__declspec
here:enet/include/enet/win32.h
Line 40 in 276ff5a
And this is only available with MSVC and with Clang when compiling for Windows.
closing
vscloses
andfixing
vsfixes
.... will add it to my next pull request again.