Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text exercises: Replace feedback modal with inline feedback view #9395

Open
wants to merge 126 commits into
base: develop
Choose a base branch
from

Commits on Sep 12, 2024

  1. Add new router link to pick submission, improve error handling and ui…

    …, add text blocks
    = Enea_Gore committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    cd72413 View commit details
    Browse the repository at this point in the history
  2. minor fixes

    = Enea_Gore committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    10dd7a4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    31bac76 View commit details
    Browse the repository at this point in the history
  4. remove no longer used history results scrollable option

    = Enea_Gore committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2f0e6ad View commit details
    Browse the repository at this point in the history
  5. fix cannot find getAll in test

    = Enea_Gore committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    4183099 View commit details
    Browse the repository at this point in the history
  6. details

    = Enea_Gore committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    7a949e9 View commit details
    Browse the repository at this point in the history
  7. ngtooltip -> tooltip

    = Enea_Gore committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2338dcd View commit details
    Browse the repository at this point in the history
  8. ngtooltip -> tooltip

    = Enea_Gore committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    ee18bbd View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. clean up code and more fixed tests

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    82c5491 View commit details
    Browse the repository at this point in the history
  2. mock getAll function in tests

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    cef96ed View commit details
    Browse the repository at this point in the history
  3. more tests

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a9c3e68 View commit details
    Browse the repository at this point in the history
  4. more tests

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    629d964 View commit details
    Browse the repository at this point in the history
  5. remove unused imports

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    53bc43f View commit details
    Browse the repository at this point in the history
  6. reduce codacy complexity

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a641a7c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    136928a View commit details
    Browse the repository at this point in the history
  8. more tests, cleaner timeline

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    8b98e0f View commit details
    Browse the repository at this point in the history
  9. last is possibly undefined

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    bec70f4 View commit details
    Browse the repository at this point in the history
  10. improve coverage further

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    eb7549d View commit details
    Browse the repository at this point in the history
  11. more result component tests

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    9f581d9 View commit details
    Browse the repository at this point in the history
  12. fix is possibly undefined in tests

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    6bf027f View commit details
    Browse the repository at this point in the history
  13. and another one (tests)

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    e5fd0ba View commit details
    Browse the repository at this point in the history
  14. even more tests

    = Enea_Gore committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    8e3828a View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Configuration menu
    Copy the full SHA
    f0a0192 View commit details
    Browse the repository at this point in the history
  2. handle possibly undefined submissions array

    = Enea_Gore committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    baa0c0c View commit details
    Browse the repository at this point in the history
  3. revert passing results on submit

    = Enea_Gore committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    9961e30 View commit details
    Browse the repository at this point in the history
  4. keep results but no need to push submission, make smoother result com…

    …ponent
    = Enea_Gore committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    6a449eb View commit details
    Browse the repository at this point in the history
  5. fix test

    = Enea_Gore committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    b5082ac View commit details
    Browse the repository at this point in the history
  6. unreferenced feedback exists too

    = Enea_Gore committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    3e10d01 View commit details
    Browse the repository at this point in the history
  7. assessment view exclude exam mode

    = Enea_Gore committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    ed965a8 View commit details
    Browse the repository at this point in the history
  8. and not or

    = Enea_Gore committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    4cdaf53 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    18024f7 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. only show ai feedback button if it is enabled

    = Enea_Gore committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    43df5cb View commit details
    Browse the repository at this point in the history
  2. improve translations and labels for feedback option

    = Enea_Gore committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    38c0592 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'feature/text-exercises/preliminary-feedback-view' of ht…

    …tps://github.com/ls1intum/Artemis into feature/text-exercises/preliminary-feedback-view
    = Enea_Gore committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    9ed844e View commit details
    Browse the repository at this point in the history
  4. show athena results even before the assessment due date

    = Enea_Gore committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    246e25c View commit details
    Browse the repository at this point in the history
  5. add preliminary tag, and default to latest submission if given submis…

    …sionId doesnt exist
    = Enea_Gore committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    ecfd8e2 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. allow feedback requests if date is not set

    = Enea_Gore committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    b518281 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. address feedback on PR, hide ai button after deadline, show timeline …

    …only if length > 1, remove unused code. fix tests
    = Enea_Gore committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    81f885d View commit details
    Browse the repository at this point in the history
  2. dont send tutor result before assessment due date

    = Enea_Gore committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    312cc5a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8aeb55e View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Configuration menu
    Copy the full SHA
    0817502 View commit details
    Browse the repository at this point in the history
  2. fix result ratings and typos

    = Enea_Gore committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    3beb2db View commit details
    Browse the repository at this point in the history
  3. Merge branch 'feature/text-exercises/preliminary-feedback-view' of ht…

    …tps://github.com/ls1intum/Artemis into feature/text-exercises/preliminary-feedback-view
    = Enea_Gore committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    4deae4e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2a12293 View commit details
    Browse the repository at this point in the history
  5. add new tests for rating component and text exercise resource with at…

    …hena
    = Enea_Gore committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    2ba858b View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. branch coverage

    = Enea_Gore committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    ca3fa04 View commit details
    Browse the repository at this point in the history
  2. no left side optional chaining

    = Enea_Gore committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    cc5a0d8 View commit details
    Browse the repository at this point in the history
  3. add tests for html elements in text editor

    = Enea_Gore committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    1a70ef6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a490cfe View commit details
    Browse the repository at this point in the history
  5. revert changes to text feedback tests

    = Enea_Gore committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    e5bed25 View commit details
    Browse the repository at this point in the history
  6. Merge branch 'feature/text-exercises/preliminary-feedback-view' of ht…

    …tps://github.com/ls1intum/Artemis into feature/text-exercises/preliminary-feedback-view
    = Enea_Gore committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2cd13dc View commit details
    Browse the repository at this point in the history
  7. test more branches

    = Enea_Gore committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    aa9e64e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b55ff4d View commit details
    Browse the repository at this point in the history
  9. copmonent -> comp

    = Enea_Gore committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b4dc5fb View commit details
    Browse the repository at this point in the history
  10. fix test

    = Enea_Gore committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    19693da View commit details
    Browse the repository at this point in the history
  11. Merge branch 'feature/text-exercises/preliminary-feedback-view' of ht…

    …tps://github.com/ls1intum/Artemis into feature/text-exercises/preliminary-feedback-view
    = Enea_Gore committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    0f067a7 View commit details
    Browse the repository at this point in the history
  12. fix issue where athena result needs to be deleted on submit causing i…

    …nternal server error
    = Enea_Gore committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    fc48fec View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. add translations for preconditions not met server side

    = Enea_Gore committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    81c9355 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ee18df7 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Configuration menu
    Copy the full SHA
    9748390 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Configuration menu
    Copy the full SHA
    3906d8f View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. refactor java test files

    = Enea_Gore committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    8a5d843 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d1b3812 View commit details
    Browse the repository at this point in the history
  3. remove unused imports, add new imports

    = Enea_Gore committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    2fb4a28 View commit details
    Browse the repository at this point in the history
  4. use test repositories

    = Enea_Gore committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    af864cc View commit details
    Browse the repository at this point in the history
  5. disable request button if no answer has been written and add margins …

    …for request button
    = Enea_Gore committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e809a22 View commit details
    Browse the repository at this point in the history
  6. possibly undefined answer

    = Enea_Gore committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    2e2217d View commit details
    Browse the repository at this point in the history
  7. bootstrap css button spacing

    = Enea_Gore committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    5fd5e47 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f427f09 View commit details
    Browse the repository at this point in the history
  9. possibly undefined

    = Enea_Gore committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e3fe09b View commit details
    Browse the repository at this point in the history
  10. better styling

    = Enea_Gore committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    90048d3 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. Configuration menu
    Copy the full SHA
    65a30ac View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Configuration menu
    Copy the full SHA
    6f0eae5 View commit details
    Browse the repository at this point in the history
  2. condition, address pending changes before request, add tests, transla…

    …tions
    = Enea_Gore committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    0d44816 View commit details
    Browse the repository at this point in the history
  3. pending changes test case

    = Enea_Gore committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    2045085 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Configuration menu
    Copy the full SHA
    8269e56 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. Configuration menu
    Copy the full SHA
    a1cdf58 View commit details
    Browse the repository at this point in the history
  2. fix merge conflicts

    = Enea_Gore committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    9eb9f62 View commit details
    Browse the repository at this point in the history
  3. fix issue from merge conflicts

    = Enea_Gore committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    782e352 View commit details
    Browse the repository at this point in the history
  4. Use check circle instead of question circle for successful athena res…

    …ults
    = Enea_Gore committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    5044481 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    892becf View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ece86d8 View commit details
    Browse the repository at this point in the history
  7. Update text-editor.component.html

    Only show the result view if: there is a non automatic result or the read only with result tag is set to true
    EneaGore authored Oct 12, 2024
    Configuration menu
    Copy the full SHA
    7e69350 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b4c59b9 View commit details
    Browse the repository at this point in the history
  9. try to fix e2e text test

    = Enea_Gore committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    bfc9220 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. Configuration menu
    Copy the full SHA
    a4fbe0f View commit details
    Browse the repository at this point in the history
  2. fix e2e

    = Enea_Gore committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    ade062b View commit details
    Browse the repository at this point in the history
  3. simplify click open exercise

    = Enea_Gore committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    f5b6e00 View commit details
    Browse the repository at this point in the history
  4. try to do it like programming e2e tests do it

    = Enea_Gore committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    24ce0a0 View commit details
    Browse the repository at this point in the history
  5. e2e text assessment save dates of exercise

    = Enea_Gore committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    442c227 View commit details
    Browse the repository at this point in the history
  6. fix issue with due date not being recognized as a date

    = Enea_Gore committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    d1ed4dc View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5f1f678 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0c28978 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Configuration menu
    Copy the full SHA
    df45a31 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Configuration menu
    Copy the full SHA
    8ef82fd View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Configuration menu
    Copy the full SHA
    5e0be6d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fddcc55 View commit details
    Browse the repository at this point in the history
  3. sorted results exist if participation results exist

    = Enea_Gore committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    a4f3af3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    630901b View commit details
    Browse the repository at this point in the history
  5. not null assertion

    = Enea_Gore committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    430e9c4 View commit details
    Browse the repository at this point in the history
  6. return if participation is undefined in update participation and skip…

    … rating check in open exercise
    = Enea_Gore committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    29c1ff2 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Configuration menu
    Copy the full SHA
    a3c5dd0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6582ce6 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. Configuration menu
    Copy the full SHA
    1e44153 View commit details
    Browse the repository at this point in the history
  2. Reuse the request feedback button in exercise details student actions…

    … for text and modelling
    = Enea_Gore committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    c56e718 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cffbb72 View commit details
    Browse the repository at this point in the history
  4. typo

    = Enea_Gore committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    3d18576 View commit details
    Browse the repository at this point in the history
  5. remove editor tests and remove unused imports

    = Enea_Gore committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    06f69b9 View commit details
    Browse the repository at this point in the history
  6. use the is generating feedback flag to show spinner

    = Enea_Gore committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    5fbfc91 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ad4f123 View commit details
    Browse the repository at this point in the history
  8. typo

    EneaGore authored Oct 26, 2024
    Configuration menu
    Copy the full SHA
    11d13fb View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2024

  1. import jhi button

    EneaGore authored Oct 27, 2024
    Configuration menu
    Copy the full SHA
    619e06c View commit details
    Browse the repository at this point in the history
  2. default value false for generating feedback

    = Enea_Gore committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    2287096 View commit details
    Browse the repository at this point in the history
  3. dont use jhi button after all to keep it consistant

    = Enea_Gore committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    7914b2f View commit details
    Browse the repository at this point in the history
  4. Make sure button is disabled when it needs to be

    = Enea_Gore committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    99f6750 View commit details
    Browse the repository at this point in the history
  5. fix translation for text feedback service

    = Enea_Gore committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    085c6ee View commit details
    Browse the repository at this point in the history
  6. test branch improvements

    = Enea_Gore committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    ba0b45c View commit details
    Browse the repository at this point in the history
  7. fix tests

    = Enea_Gore committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    950f3a1 View commit details
    Browse the repository at this point in the history
  8. prettier style

    EneaGore authored Oct 27, 2024
    Configuration menu
    Copy the full SHA
    a4e7b2b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b265a3b View commit details
    Browse the repository at this point in the history
  10. fix condition

    = Enea_Gore committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    9380218 View commit details
    Browse the repository at this point in the history
  11. input<> syntax

    = Enea_Gore committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    fe845be View commit details
    Browse the repository at this point in the history
  12. Merge branch 'feature/text-exercises/replace-modal-with-inline-feedba…

    …ck' of https://github.com/ls1intum/Artemis into feature/text-exercises/replace-modal-with-inline-feedback
    = Enea_Gore committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    be59db6 View commit details
    Browse the repository at this point in the history
  13. Make sure the button knows without refreshing if it submission is sub…

    …mitted
    = Enea_Gore committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    7c466a4 View commit details
    Browse the repository at this point in the history
  14. fix test

    = Enea_Gore committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    ba65dc0 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Configuration menu
    Copy the full SHA
    e6fae3a View commit details
    Browse the repository at this point in the history