chore: Refactor proactivity settings according to iris settings v3 #818
check-aeolus-scripts.yml
on: push
Check if windfiles and scripts match
55s
Annotations
18 errors
de.tum.cit.aet.artemis.iris.architecture.IrisRepositoryArchitectureTest ► enforceUsageOfTestRepository():
src/test/java/de/tum/cit/aet/artemis/shared/architecture/module/AbstractModuleRepositoryArchitectureTest.java#L219
Failed test found in:
build/test-results/test/TEST-de.tum.cit.aet.artemis.iris.architecture.IrisRepositoryArchitectureTest.xml
Error:
java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'classes that reside in a package 'de.tum.cit.aet.artemis.iris..' should not use repositories with subclasses, because Test Repositories should be used over production repositories, if such a repository exist.' was violated (1 times):
|
de.tum.cit.aet.artemis.programming.architecture.ProgrammingRepositoryArchitectureTest ► usedInProductionCode():
src/test/java/de/tum/cit/aet/artemis/shared/architecture/module/AbstractModuleRepositoryArchitectureTest.java#L206
Failed test found in:
build/test-results/test/TEST-de.tum.cit.aet.artemis.programming.architecture.ProgrammingRepositoryArchitectureTest.xml
Error:
java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'methods that are declared in classes that reside in a package 'de.tum.cit.aet.artemis.programming..' and are declared in classes that are annotated with @repository and are declared in classes that should be used by production code, because methods that are not used in production code should be moved to test repositories' was violated (1 times):
|
de.tum.cit.aet.artemis.shared.architecture.ArchitectureTest ► testNullnessAnnotations():
src/test/java/de/tum/cit/aet/artemis/shared/architecture/ArchitectureTest.java#L145
Failed test found in:
build/test-results/test/TEST-de.tum.cit.aet.artemis.shared.architecture.ArchitectureTest.xml
Error:
java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'no code units should be annotated with not Annotation in package jakarta.annotation and Annotation with simple name Nullable' was violated (1 times):
|
test#L0
Junit Results ran 8333 in 1156.3620000000003 seconds 0 Errored, 7 Failed, 2 Skipped
|
testShouldFireJolEvent():
/home/runner/work/Artemis/Artemis/src/test/java/de/tum/cit/aet/artemis/iris/PyrisEventSystemTest.java#L162
Junit test testShouldFireJolEvent() failed org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in de.tum.cit.aet.artemis.iris.PyrisEventSystemTest was not fulfilled within 2 seconds.
|
enforceUsageOfTestRepository():
/home/runner/work/Artemis/Artemis/src/test/java/de/tum/cit/aet/artemis/iris/architecture/IrisRepositoryArchitectureTest.java#L0
Junit test enforceUsageOfTestRepository() failed java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'classes that reside in a package 'de.tum.cit.aet.artemis.iris..' should not use repositories with subclasses, because Test Repositories should be used over production repositories, if such a repository exist.' was violated (1 times):
Test class de.tum.cit.aet.artemis.iris.PyrisEventSystemTest uses repository de.tum.cit.aet.artemis.exercise.repository.SubmissionRepository which has subclasses: [JavaClass{name='de.tum.cit.aet.artemis.exercise.test_repository.SubmissionTestRepository'}]
|
getMissingSettingsForCourse():
/home/runner/work/Artemis/Artemis/src/test/java/de/tum/cit/aet/artemis/iris/settings/IrisSettingsIntegrationTest.java#L50
Junit test getMissingSettingsForCourse() failed java.lang.AssertionError:
Expecting actual:
de.tum.cit.aet.artemis.iris.domain.settings.IrisCourseSettings@0
to be equal to:
de.tum.cit.aet.artemis.iris.domain.settings.IrisCourseSettings@0
when recursively comparing field by field, but found the following difference:
field/property 'irisProactivitySettings.eventSettings' differ:
- actual value : [de.tum.cit.aet.artemis.iris.domain.settings.event.IrisJolEventSettings@0,
de.tum.cit.aet.artemis.iris.domain.settings.event.IrisBuildFailedEventSettings@0,
de.tum.cit.aet.artemis.iris.domain.settings.event.IrisProgressStalledEventSettings@0] (HashSet@415f6ad2)
- expected value: [de.tum.cit.aet.artemis.iris.domain.settings.event.IrisJolEventSettings@0,
de.tum.cit.aet.artemis.iris.domain.settings.event.IrisBuildFailedEventSettings@0,
de.tum.cit.aet.artemis.iris.domain.settings.event.IrisProgressStalledEventSettings@0] (HashSet@32f10416)
The following expected elements were not matched in the actual HashSet:
[de.tum.cit.aet.artemis.iris.domain.settings.event.IrisJolEventSettings@0, de.tum.cit.aet.artemis.iris.domain.settings.event.IrisBuildFailedEventSettings@0, de.tum.cit.aet.artemis.iris.domain.settings.event.IrisProgressStalledEventSettings@0]
The recursive comparison was performed with this configuration:
- the following fields were ignored in the comparison: id, course, irisChatSettings.id, iris_lecture_ingestion_settings_id, irisCompetencyGenerationSettings.id, irisProactivitySettings.id
- no equals methods were used in the comparison EXCEPT for java JDK types since introspecting JDK types is forbidden in java 17+ (use withEqualsForType to register a specific way to compare a JDK type if you need it)
- these types were compared with the following comparators:
- java.lang.Double -> DoubleComparator[precision=1.0E-15]
- java.lang.Float -> FloatComparator[precision=1.0E-6]
- java.nio.file.Path -> lexicographic comparator (Path natural order)
- actual and expected objects and their fields were compared field by field recursively even if they were not of the same type, this allows for example to compare a Person to a PersonDto (call strictTypeChecking(true) to change that behavior).
- the introspection strategy used was: DefaultRecursiveComparisonIntrospectionStrategy
|
getCourseSettings():
/home/runner/work/Artemis/Artemis/src/test/java/de/tum/cit/aet/artemis/iris/settings/IrisSettingsIntegrationTest.java#L64
Junit test getCourseSettings() failed java.lang.AssertionError:
Expecting actual:
de.tum.cit.aet.artemis.iris.domain.settings.IrisCourseSettings@62
to be equal to:
de.tum.cit.aet.artemis.iris.domain.settings.IrisCourseSettings@62
when recursively comparing field by field, but found the following difference:
field/property 'irisProactivitySettings.eventSettings' differ:
- actual value : [de.tum.cit.aet.artemis.iris.domain.settings.event.IrisJolEventSettings@b5,
de.tum.cit.aet.artemis.iris.domain.settings.event.IrisBuildFailedEventSettings@b6,
de.tum.cit.aet.artemis.iris.domain.settings.event.IrisProgressStalledEventSettings@b7] (HashSet@5d72ddb1)
- expected value: [de.tum.cit.aet.artemis.iris.domain.settings.event.IrisJolEventSettings@b5,
de.tum.cit.aet.artemis.iris.domain.settings.event.IrisBuildFailedEventSettings@b6,
de.tum.cit.aet.artemis.iris.domain.settings.event.IrisProgressStalledEventSettings@b7] (PersistentSet@7b6b4a05)
The following expected elements were not matched in the actual HashSet:
[de.tum.cit.aet.artemis.iris.domain.settings.event.IrisJolEventSettings@b5, de.tum.cit.aet.artemis.iris.domain.settings.event.IrisBuildFailedEventSettings@b6, de.tum.cit.aet.artemis.iris.domain.settings.event.IrisProgressStalledEventSettings@b7]
The recursive comparison was performed with this configuration:
- the following fields were ignored in the comparison: course
- no equals methods were used in the comparison EXCEPT for java JDK types since introspecting JDK types is forbidden in java 17+ (use withEqualsForType to register a specific way to compare a JDK type if you need it)
- these types were compared with the following comparators:
- java.lang.Double -> DoubleComparator[precision=1.0E-15]
- java.lang.Float -> FloatComparator[precision=1.0E-6]
- java.nio.file.Path -> lexicographic comparator (Path natural order)
- actual and expected objects and their fields were compared field by field recursively even if they were not of the same type, this allows for example to compare a Person to a PersonDto (call strictTypeChecking(true) to change that behavior).
- the introspection strategy used was: DefaultRecursiveComparisonIntrospectionStrategy
|
resumeProgrammingExerciseByTriggeringInstructorBuild_correctInitializationState(ExerciseMode) [2] exerciseMode=TEAM:
/home/runner/work/Artemis/Artemis/src/test/java/de/tum/cit/aet/artemis/programming/ProgrammingExerciseGitlabJenkinsIntegrationTest.java#L0
Junit test resumeProgrammingExerciseByTriggeringInstructorBuild_correctInitializationState(ExerciseMode) [2] exerciseMode=TEAM failed org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in de.tum.cit.aet.artemis.programming.util.ProgrammingExerciseTestService was not fulfilled within 20 seconds.
|
usedInProductionCode():
/home/runner/work/Artemis/Artemis/src/test/java/de/tum/cit/aet/artemis/programming/architecture/ProgrammingRepositoryArchitectureTest.java#L0
Junit test usedInProductionCode() failed java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'methods that are declared in classes that reside in a package 'de.tum.cit.aet.artemis.programming..' and are declared in classes that are annotated with @repository and are declared in classes that should be used by production code, because methods that are not used in production code should be moved to test repositories' was violated (1 times):
Method de.tum.cit.aet.artemis.programming.repository.ProgrammingExerciseRepository.findWithAllParticipationsById(long) is not used in production code
|
testNullnessAnnotations():
/home/runner/work/Artemis/Artemis/src/test/java/de/tum/cit/aet/artemis/shared/architecture/ArchitectureTest.java#L133
Junit test testNullnessAnnotations() failed java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'no code units should be annotated with not Annotation in package jakarta.annotation and Annotation with simple name Nullable' was violated (1 times):
Method <de.tum.cit.aet.artemis.iris.domain.settings.event.IrisEventSettings.getSelectedEventVariant()> is annotated with not Annotation in package jakarta.annotation and Annotation with simple name Nullable in (IrisEventSettings.java:121)
|
de.tum.cit.aet.artemis.iris.architecture.IrisRepositoryArchitectureTest ► enforceUsageOfTestRepository():
src/test/java/de/tum/cit/aet/artemis/shared/architecture/module/AbstractModuleRepositoryArchitectureTest.java#L219
Failed test found in:
build/test-results/test/TEST-de.tum.cit.aet.artemis.iris.architecture.IrisRepositoryArchitectureTest.xml
Error:
java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'classes that reside in a package 'de.tum.cit.aet.artemis.iris..' should not use repositories with subclasses, because Test Repositories should be used over production repositories, if such a repository exist.' was violated (1 times):
|
de.tum.cit.aet.artemis.iris.PyrisEventSystemTest ► testShouldFireJolEvent():
src/test/java/de/tum/cit/aet/artemis/iris/PyrisEventSystemTest.java#L171
Failed test found in:
build/test-results/test/TEST-de.tum.cit.aet.artemis.iris.PyrisEventSystemTest.xml
Error:
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in de.tum.cit.aet.artemis.iris.PyrisEventSystemTest was not fulfilled within 2 seconds.
|
de.tum.cit.aet.artemis.iris.settings.IrisSettingsIntegrationTest ► getMissingSettingsForCourse():
src/test/java/de/tum/cit/aet/artemis/iris/settings/IrisSettingsIntegrationTest.java#L59
Failed test found in:
build/test-results/test/TEST-de.tum.cit.aet.artemis.iris.settings.IrisSettingsIntegrationTest.xml
Error:
java.lang.AssertionError:
|
de.tum.cit.aet.artemis.iris.settings.IrisSettingsIntegrationTest ► getCourseSettings():
src/test/java/de/tum/cit/aet/artemis/iris/settings/IrisSettingsIntegrationTest.java#L76
Failed test found in:
build/test-results/test/TEST-de.tum.cit.aet.artemis.iris.settings.IrisSettingsIntegrationTest.xml
Error:
java.lang.AssertionError:
|
de.tum.cit.aet.artemis.programming.architecture.ProgrammingRepositoryArchitectureTest ► usedInProductionCode():
src/test/java/de/tum/cit/aet/artemis/shared/architecture/module/AbstractModuleRepositoryArchitectureTest.java#L206
Failed test found in:
build/test-results/test/TEST-de.tum.cit.aet.artemis.programming.architecture.ProgrammingRepositoryArchitectureTest.xml
Error:
java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'methods that are declared in classes that reside in a package 'de.tum.cit.aet.artemis.programming..' and are declared in classes that are annotated with @repository and are declared in classes that should be used by production code, because methods that are not used in production code should be moved to test repositories' was violated (1 times):
|
de.tum.cit.aet.artemis.programming.ProgrammingExerciseGitlabJenkinsIntegrationTest ► resumeProgrammingExerciseByTriggeringInstructorBuild_correctInitializationState(ExerciseMode) [2] exerciseMode=TEAM:
src/test/java/de/tum/cit/aet/artemis/programming/util/ProgrammingExerciseTestService.java#L1483
Failed test found in:
build/test-results/test/TEST-de.tum.cit.aet.artemis.programming.ProgrammingExerciseGitlabJenkinsIntegrationTest.xml
Error:
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in de.tum.cit.aet.artemis.programming.util.ProgrammingExerciseTestService was not fulfilled within 20 seconds.
|
de.tum.cit.aet.artemis.shared.architecture.ArchitectureTest ► testNullnessAnnotations():
src/test/java/de/tum/cit/aet/artemis/shared/architecture/ArchitectureTest.java#L145
Failed test found in:
build/test-results/test/TEST-de.tum.cit.aet.artemis.shared.architecture.ArchitectureTest.xml
Error:
java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'no code units should be annotated with not Annotation in package jakarta.annotation and Annotation with simple name Nullable' was violated (1 times):
|