Feature: Event and Task Type Selection
#321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/i18n/de.json # src/main/i18n/en.json # src/main/packages/bpmn/bpmn-diagram-preview.ts # src/main/packages/bpmn/index.ts # src/main/packages/components.ts # src/main/packages/popups.ts # src/main/packages/uml-elements.ts # src/tests/unit/packages/bpmn/bpmn-annotation/bpmn-annotation-component-test.tsx # src/tests/unit/packages/bpmn/bpmn-call-activity/bpmn-call-activity-component-test.tsx # src/tests/unit/packages/bpmn/bpmn-conversation/bpmn-conversation-component-test.tsx # src/tests/unit/packages/bpmn/bpmn-end-event/bpmn-end-event-component-test.tsx # src/tests/unit/packages/bpmn/bpmn-flow/bpmn-flow-component-test.tsx # src/tests/unit/packages/bpmn/bpmn-gateway/bpmn-gateway-component-test.tsx # src/tests/unit/packages/bpmn/bpmn-intermediate-event/bpmn-intermediate-event-component-test.tsx # src/tests/unit/packages/bpmn/bpmn-start-event/bpmn-start-event-component-test.tsx # src/tests/unit/packages/bpmn/bpmn-subprocess/bpmn-subprocess-component-test.tsx # src/tests/unit/packages/bpmn/bpmn-task/bpmn-task-component-test.tsx # src/tests/unit/packages/bpmn/bpmn-transaction/bpmn-transaction-component-test.tsx
# Conflicts: # src/main/i18n/de.json # src/main/i18n/en.json # src/main/packages/bpmn/bpmn-diagram-preview.ts # src/main/packages/bpmn/index.ts # src/main/packages/components.ts # src/main/packages/uml-elements.ts
# Conflicts: # src/main/packages/bpmn/bpmn-end-event/bpmn-end-event.ts # src/main/packages/bpmn/bpmn-gateway/bpmn-gateway-component.tsx # src/main/packages/bpmn/bpmn-gateway/bpmn-gateway-update.tsx # src/main/packages/bpmn/bpmn-gateway/bpmn-gateway.ts # src/main/packages/bpmn/bpmn-pool/bpmn-pool-update.tsx # src/main/packages/bpmn/bpmn-start-event/bpmn-start-event.ts # src/main/packages/popups.ts
…tum/Apollon into feature/bpmn-2.0-adaptions
matthiaslehnertum
requested review from
loreanvictor and
AlexanderG2207
and removed request for
loreanvictor
|
ok the functionality seems to work as intended, saving / loading state works, exporting works fine for the new elements and tests are passing. I would have a few small suggestions (some of these can also be added on a follow up PR I suppose):
|
loreanvictor
previously approved these changes
Nov 27, 2023
|
@loreanvictor I increased the test coverage, thank you for the remark! The incorrect positioning of the update dialog seems to be a general issue not directly related to this PR. I will try to fix that one in another PR! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends Apollon by the ability to select event types more specific than just start, intermediate and end events.
Start Event
Update dialog of the Start Event
All available Start Event types
Intermediate Event
Update dialog of the Intermediate Event
All available Intermediate Event types
End Event
Update dialog of the End Event
All available End Event types
Checklist
Motivation and Context
To fully comply with the BPMN 2.0 standard, events and tasks need to allow for specifying specialisations.
Steps for Testing
For Events
Drag any event onto the canvas, double click it and select an event type.
For Tasks
Drag any task onto the canvas, double click and select a task type.