Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity diagrams: Add horizontal fork node #245

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

minrows
Copy link
Contributor

@minrows minrows commented Jun 28, 2022

Checklist

  • I added multiple screenshots/screencasts of my UI changes

Motivation and Context

This PR introduces a Horizontal fork node for Activity Diagrams.
Issue Number: #240

Description

Horizontal fork node for drawing Activity/Sequence diagram was not possible in Apollon.
In order to solve this problem, a new Horizontal fork node is now introduced.

Steps for Testing

  1. Clone a repo
  2. Execute commands: yarn install yarn build followed by yarn start
  3. Goto the application, navigating to URL: localhost:8888
  4. Select Activity Diagram from Diagram Type
  5. Observe new horizontal activity node ready to be used

OR

  1. Go to test server
  2. Observe new element Horizontal fork node in the list of Activity/Class Diagram

Screenshots

image (3)

Additional Info:

Changes included in Release version: 2.10.4-alpha.2

@minrows minrows added the enhancement New feature or request label Jun 28, 2022
@minrows minrows self-assigned this Jun 28, 2022
Copy link

@akesfeden akesfeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, horizontal activity node is visible and usable. When I try to resize the node, the cursor shows diagonal arrows but I think having an horizontal arrow would be more correct. But maybe this is outside of the scope of this PR because it also happens with vertical activity node.

Apollon - Google Chrome 2022-06-29 02-29-20

@minrows
Copy link
Contributor Author

minrows commented Jun 29, 2022

Yes @akesfeden , this PR is just for the addition of a new element, which is a Horizontal Fork node, and that behavior is out of scope.
But thanks for the feedback. That can be enhanced on separate PR. 👍

Copy link

@canberkanar canberkanar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Apollon TS1 in the testing session. Although there are no junction points on the corners, the algorithm still connects the arrows there on some occasions as well. Developer informed that it is intentional so the PR is approved.

image

Copy link

@ole-ve ole-ve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested during TS, worked fine 👍

Copy link

@xlieA xlieA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested during testing session. Works as described.

@krusche krusche changed the title Development: Addition of horizontal fork node for Activity Diagrams Activity diagrams: Add horizontal fork node Jun 30, 2022
@krusche krusche merged commit 47e5c9b into develop Jun 30, 2022
@krusche krusche deleted the feature/new-horizontal-fork-node branch June 30, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:critical
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants