-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update of vendor id #648
Open
MatrixMike
wants to merge
4
commits into
lpereira:master
Choose a base branch
from
ElectronicsClubAltona:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
update of vendor id #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the PR!
"updatepo.sh" should only be ran if you want to update the .po files for translation after adding new strings and before a new release. Changing the vendor.ids won't require that as it's an independent mechanism; the sync server will eventually catch up automatically. I can cherry-pick myself but this might take a while as I'm a bit away from my computer this week.
…On Wed, May 4, 2022, at 5:16 AM, Mike Hewitt wrote:
I tested the freshly built software with a Cypress USB (to PS2) adapter {keyboard and mouse}. A random test just an old device near to hand. I use Cypress PSoC devices - BLE etc so was aware of the company name change {absorption into infineon}. I have changed the vendor name for that USB id. This reflects the info at top of the Wikipedia page for Cypress.
I enjoy using diagnostic tools and like to have them as accurate as possible. I submit this as a pull request also partly to see if this system is being monitored.
I ran the 'bash updatepo.sh' but after this pull request. I can submit with that later.
You can view, comment on, or merge this pull request online at:
#648
Commit Summary
* 9ea1520 <9ea1520> following recommendation
* 16f8c71 <16f8c71> Cypress vendor changed
File Changes
(2 files <https://github.com/lpereira/hardinfo/pull/648/files>)
* *M* CMakeLists.txt <https://github.com/lpereira/hardinfo/pull/648/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a> (4)
* *M* data/vendor.ids <https://github.com/lpereira/hardinfo/pull/648/files#diff-d4965e957041a4491a3da5112b46f3bfab178b91e21795d0d7059255faab4546> (2)
Patch Links:
* https://github.com/lpereira/hardinfo/pull/648.patch
* https://github.com/lpereira/hardinfo/pull/648.diff
—
Reply to this email directly, view it on GitHub <#648>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAADVGKPYLMVAMT42ZO5TATVIJTALANCNFSM5VBZBC4Q>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Thanks for your reply. I am slightly confused as to what my actions should be now. I can wait for the robots to pick up the request and process it over the weekend.
I enjoy working on this sort of stuff.
Best regards and for whatever it is worth ‘happy mothers’ day. No happy mother near me but you might have a good one.
… On 4 May 2022, at 23:49, L. A. F. Pereira ***@***.***> wrote:
Thanks for the PR!
"updatepo.sh" should only be ran if you want to update the .po files for translation after adding new strings and before a new release. Changing the vendor.ids won't require that as it's an independent mechanism; the sync server will eventually catch up automatically. I can cherry-pick myself but this might take a while as I'm a bit away from my computer this week.
On Wed, May 4, 2022, at 5:16 AM, Mike Hewitt wrote:
>
> I tested the freshly built software with a Cypress USB (to PS2) adapter {keyboard and mouse}. A random test just an old device near to hand. I use Cypress PSoC devices - BLE etc so was aware of the company name change {absorption into infineon}. I have changed the vendor name for that USB id. This reflects the info at top of the Wikipedia page for Cypress.
> I enjoy using diagnostic tools and like to have them as accurate as possible. I submit this as a pull request also partly to see if this system is being monitored.
> I ran the 'bash updatepo.sh' but after this pull request. I can submit with that later.
>
>
> You can view, comment on, or merge this pull request online at:
>
> #648
>
> Commit Summary
>
> * 9ea1520 <9ea1520> following recommendation
> * 16f8c71 <16f8c71> Cypress vendor changed
> File Changes
>
> (2 files <https://github.com/lpereira/hardinfo/pull/648/files>)
>
> * *M* CMakeLists.txt <https://github.com/lpereira/hardinfo/pull/648/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a> (4)
> * *M* data/vendor.ids <https://github.com/lpereira/hardinfo/pull/648/files#diff-d4965e957041a4491a3da5112b46f3bfab178b91e21795d0d7059255faab4546> (2)
> Patch Links:
>
> * https://github.com/lpereira/hardinfo/pull/648.patch
> * https://github.com/lpereira/hardinfo/pull/648.diff
>
> —
> Reply to this email directly, view it on GitHub <#648>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAADVGKPYLMVAMT42ZO5TATVIJTALANCNFSM5VBZBC4Q>.
> You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
>
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
I've merged this patch, but only the changes to the vendors file (plus the change in the AUTHORS.md). I have not merged the changes to the po files as they haven't been changed by the vendor file change.
…On Thu, May 5, 2022, at 9:49 AM, Mike Hewitt wrote:
Thanks for your reply. I am slightly confused as to what my actions should be now. I can wait for the robots to pick up the request and process it over the weekend.
I enjoy working on this sort of stuff.
Best regards and for whatever it is worth ‘happy mothers’ day. No happy mother near me but you might have a good one.
> On 4 May 2022, at 23:49, L. A. F. Pereira ***@***.***> wrote:
>
> Thanks for the PR!
>
> "updatepo.sh" should only be ran if you want to update the .po files for translation after adding new strings and before a new release. Changing the vendor.ids won't require that as it's an independent mechanism; the sync server will eventually catch up automatically. I can cherry-pick myself but this might take a while as I'm a bit away from my computer this week.
>
> On Wed, May 4, 2022, at 5:16 AM, Mike Hewitt wrote:
> >
> > I tested the freshly built software with a Cypress USB (to PS2) adapter {keyboard and mouse}. A random test just an old device near to hand. I use Cypress PSoC devices - BLE etc so was aware of the company name change {absorption into infineon}. I have changed the vendor name for that USB id. This reflects the info at top of the Wikipedia page for Cypress.
> > I enjoy using diagnostic tools and like to have them as accurate as possible. I submit this as a pull request also partly to see if this system is being monitored.
> > I ran the 'bash updatepo.sh' but after this pull request. I can submit with that later.
> >
> >
> > You can view, comment on, or merge this pull request online at:
> >
> > #648
> >
> > Commit Summary
> >
> > * 9ea1520 <9ea1520> following recommendation
> > * 16f8c71 <16f8c71> Cypress vendor changed
> > File Changes
> >
> > (2 files <https://github.com/lpereira/hardinfo/pull/648/files>)
> >
> > * *M* CMakeLists.txt <https://github.com/lpereira/hardinfo/pull/648/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a> (4)
> > * *M* data/vendor.ids <https://github.com/lpereira/hardinfo/pull/648/files#diff-d4965e957041a4491a3da5112b46f3bfab178b91e21795d0d7059255faab4546> (2)
> > Patch Links:
> >
> > * https://github.com/lpereira/hardinfo/pull/648.patch
> > * https://github.com/lpereira/hardinfo/pull/648.diff
> >
> > —
> > Reply to this email directly, view it on GitHub <#648>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAADVGKPYLMVAMT42ZO5TATVIJTALANCNFSM5VBZBC4Q>.
> > You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
> >
> —
> Reply to this email directly, view it on GitHub, or unsubscribe.
> You are receiving this because you authored the thread.
—
Reply to this email directly, view it on GitHub <#648 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAADVGKMU3OBIURIEDP4BBLVIOKSXANCNFSM5VBZBC4Q>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested the freshly built software with a Cypress USB (to PS2) adapter {keyboard and mouse}. A random test just an old device near to hand. I use Cypress PSoC devices - BLE etc so was aware of the company name change {absorption into infineon}. I have changed the vendor name for that USB id. This reflects the info at top of the Wikipedia page for Cypress.
I enjoy using diagnostic tools and like to have them as accurate as possible. I submit this as a pull request also partly to see if this system is being monitored.
I ran the 'bash updatepo.sh' but after this pull request. I can submit with that later.