[discussion] struct info free/no-free sets #411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lpereira, what do you think about just having two sets for name, value, icon, tag, where one set is const and the other always gets freed? The the proper member can just be set for whichever is appropriate. If the string should be owned by the info field struct set .name, if not set .name_const, etc, This replaces the free_on_flatten members for each one. The info_field_get_*() macros return whichever is set for convenience.
This PR implements the idea in info.{h,c} but doesn't change any uses of it, so don't expect it to compile.