Fixed memory leak and cleaned up addNode #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also fixed insertNode(). Otherwise it would only insert into the second position |
DVD-DAVIDE
reviewed
Jan 13, 2023
| Node *new = malloc(sizeof(Node)); | ||
| if (new == NULL) | ||
| return NULL; | ||
|
|
||
| // two cases: | ||
|
|
||
| // if the list is empty. | ||
| if (head == NULL) |
There was a problem hiding this comment.
In the case of head being null, wouldn't doing new->next = NULL the same as new->next = head ?
There was a problem hiding this comment.
Insert have error. If cueernt is NULL, empty list, you try to do current->next on Null Pointer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a memory leak in removeNode, where the node is not deallocated if it is the first node in the list, and the addNode function only needs the call to malloc to occur in one place.
I saw the comment that noticed the mistake, I'm not the person that left it though.