This repository has been archived by the owner on Sep 10, 2023. It is now read-only.
Improving keyboard management and fix timing issues #816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues :
despite setTimeout(), which causes do_search() to perform over the
previous value of the field.
which is then confused for KEY.NUMPAD_ENTER (keyCode 108).
Fixes :
https://github.com/jquery/jquery-ui/blob/e9643f6bfc922773e29e3084e64de0240b547f32/ui/core.js
https://api.jquery.com/event.which/
http://www.quirksmode.org/dom/events/keys.html
** Keydown event is used to detect control keys (when the key is
pressed, meaning that the effect of the key can be overloaded before it
happens)
** Keyup event is used to act upon input changes (when the key is
released, meaning that the effect of the key has already happened)
** Keypress event is not used anymore
** Now that do_search() performs only on keyup, the setTimeout() ("just
long enough to let this function finish.") seems useless.
"return false"