make clickhouse-cityhash dependency optional #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Please fix the CI |
|
done 🤞, maybe could allow my workflows to run without awaiting approval? |
|
Which is just for first time contributor. Please fix the test, thanks! |
|
@long2ice any chance you could approve the workflow? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per xzkostyan/clickhouse-cityhash#3
clickhouse-cityhashcan't currently be installed on M1 macs, it's also not required in many scenariois.The solution is to only import it when it needs to be used, and make it an optional dependency.
I've installed this branch locally and it's working fine.
I'm not at all clear on how to correctly implement optional dependencies with poetry, please let me know if something needs changing here.