Switch in singular the names for the Enums classes with non-simultaneously-coexisting-values
#119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stankudrow
commented
Oct 17, 2024
| @@ -141,7 +141,7 @@ async def fetchone(self): | |||
| if self._stream_results: | |||
| try: | |||
| return await self._rows.next() | |||
| except: # noqa: E722 | |||
| except Exception: | |||
stankudrow
changed the title
Enum classes singular Enums classes with non-simultaneously-coexisting-values
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some inquiries on enumeration naming guidelines, I realised that it might be a nice idea to have the non bit-field or multiple-flag enumerations singular. the existing enums bear rather mutual exclusive values which cannot be set simultaneously. The rationale -> nats-io/nats.py#619 (comment) .
This PR is important to be considered before the asynch new version release ( the issue #116 ) since it would be easier to handle this now until the enums become a part of public API.