-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add social identity #6703
base: master
Are you sure you want to change the base?
Conversation
COMPARE TO
|
Name | Diff |
---|---|
packages/core/src/libraries/user.ts | 📈 +284 Bytes |
packages/core/src/routes/experience/classes/verifications/social-verification.ts | 📈 +676 Bytes |
packages/core/src/routes/interaction/utils/social-verification.ts | 📈 +558 Bytes |
packages/core/src/routes/profile/index.openapi.json | 📈 +1.04 KB |
packages/core/src/routes/profile/index.ts | 📈 +1.59 KB |
packages/core/src/routes/verification/index.openapi.json | 📈 +3.07 KB |
packages/core/src/routes/verification/index.ts | 📈 +2.04 KB |
packages/integration-tests/src/api/profile.ts | 📈 +257 Bytes |
packages/integration-tests/src/api/verification-record.ts | 📈 +801 Bytes |
packages/integration-tests/src/tests/api/profile/social.test.ts | 📈 +5.66 KB |
6ed9c2e
to
bec3a7f
Compare
payload: SocialAuthorizationUrlPayload, | ||
{ | ||
setSession, | ||
jti, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a different name? Just to better distinguish with interaction jti.
{ | ||
setSession: async (connectorSession) => { | ||
this.connectorSession = connectorSession; | ||
}, | ||
jti: this.id, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to create separate social createSocialAuthorizationUrl
and verifySocialIdentity
methods without the dependency on the interaction session? So we can keep the flow isolated.
Summary
Implement linking new social identities in profile API.
Steps to link a new social identity:
POST /verificiations/social
to create a record and getauthorizationUri
POST /verifications/social/verify
with the connector data to verifyThis PR also add some changes to
SocialVerification
, it no longer relys on "interaction session".Testing
Integration tests.
Checklist
.changeset