Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allowing the base url to be overridden for the nuxt package #764

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

allowing the base url to be overridden for the nuxt package #764

wants to merge 2 commits into from

Conversation

funkel1989
Copy link

Summary

Implements the ability to provide an override for the base url in the nuxt js package.

Testing

ran it against my website

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

@funkel1989
Copy link
Author

this resolved #763

@funkel1989
Copy link
Author

I doubt this PR meets all the expected quality and testing standards your team requires but i've left there here for you all to discuss and figure out how to move forward with. I needed to make this change for the logto nuxt package to work with my site until your team can provide a different solution.

@funkel1989 funkel1989 marked this pull request as ready for review July 28, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangsijie wangsijie wangsijie left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@funkel1989 @wangsijie