Hopsworks Python library installation documentation improvements #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SirOibaf
commented
Jan 2, 2025
•
SirOibaf
commented
- Remove references to pip install hsfs and hsfs.connection()
- Improve the documentation for the installation of the Python library (Including profiles)
- Add documentation for the installation of the Java library
- Remmove references to pip install hsfs and hsfs.connection() - Improve the documentation for the installation of the Python library (Including profiles) - Add documentation for the installation of the Java library
rcnnnghm
approved these changes
Jan 3, 2025
jimdowling
approved these changes
Jan 3, 2025
| pip install hsfs[python] | ||
| # or if using zsh | ||
| pip install 'hsfs[python]' | ||
| pip install hopsworks[python,great-expectations,polars] |
There was a problem hiding this comment.
Is Polars not just an extension of the python profile?
Is this not enough:
pip install hopsworks[polars,great-expectations]
There was a problem hiding this comment.
Doesn't look like from the project configuration: https://github.com/logicalclocks/hopsworks-api/blob/0c93c2ab91b3962a1bc45633def1e2320eb0f1d7/python/pyproject.toml#L91 - we had to put polars on its own profile because on certain VMs the instructions set is not available and importing polars was crashing import hopsworks
SirOibaf
added a commit
that referenced
this pull request
Jan 3, 2025
* Hopsworks Python library installation documentation improvements - Remmove references to pip install hsfs and hsfs.connection() - Improve the documentation for the installation of the Python library (Including profiles) - Add documentation for the installation of the Java library * Typo * Fix for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.