Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn logic around for proxied commands check #52

Conversation

lakkeger
Copy link
Contributor

Motivation

Issue with list of proxied commands, users ended up with "backend has changed" error.

Changes

  • turned around logic, we exclude them instead of maintaining a list
  • added new env variable TF_UNPROXIED_CMDS

@lakkeger lakkeger requested review from whummer and removed request for whummer March 13, 2024 21:22
@lakkeger lakkeger force-pushed the 51-s3-backend-causes-issue-with-terraform-always-thinking-backend-configuration-has-changed branch from 4aaf3ea to fcc0872 Compare March 13, 2024 21:25
@lakkeger lakkeger force-pushed the 51-s3-backend-causes-issue-with-terraform-always-thinking-backend-configuration-has-changed branch from fcc0872 to 201dc66 Compare March 13, 2024 21:51
@lakkeger lakkeger requested a review from whummer March 13, 2024 21:56
Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @lakkeger ! LGTM 👍

@lakkeger lakkeger merged commit 07643c4 into main Mar 14, 2024
3 checks passed
@lakkeger lakkeger deleted the 51-s3-backend-causes-issue-with-terraform-always-thinking-backend-configuration-has-changed branch March 14, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s3 backend causes issue with terraform always thinking backend configuration has changed
2 participants