Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix s3 path detection #27

Merged
merged 2 commits into from
Sep 20, 2023
Merged

fix s3 path detection #27

merged 2 commits into from
Sep 20, 2023

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Sep 18, 2023

This PR would fix #26, or at least propose an easy workaround by setting S3_HOSTNAME=localstack while deploying with tflocal, which would force it to use s3_path_style=true. Right now, there's no easy way to force tflocal to use path style automatically except by setting the S3 endpoint to localhost.

I've improved the detection to be in line with LocalStack, where any request not starting with the s3. prefix would not be considered virtual host and would fail.

@bentsku bentsku self-assigned this Sep 18, 2023
Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, thanks for jumping on this one @bentsku ! 🎉 Can you please bump the version and add a short entry to the change log, then we could release this right away.. 👍

@bentsku bentsku merged commit 1aedeef into main Sep 20, 2023
1 check passed
@bentsku bentsku deleted the fix-s3-path-detection branch September 20, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s3 access problem using compose
2 participants