Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would fix #26, or at least propose an easy workaround by setting
S3_HOSTNAME=localstack
while deploying withtflocal
, which would force it to uses3_path_style=true
. Right now, there's no easy way to forcetflocal
to use path style automatically except by setting the S3 endpoint tolocalhost
.I've improved the detection to be in line with LocalStack, where any request not starting with the
s3.
prefix would not be consideredvirtual host
and would fail.