update the docs to use image rather than extension #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview has been successfully built and deployed to https://localstack-snowflake-docs-preview-pr-33.surge.sh 🎊 |
ackdav
reviewed
May 28, 2024
| @@ -18,23 +18,19 @@ This guide explains how to set up the Snowflake emulator and develop a Python pr | |||
|
|
|||
| ## Instructions | |||
|
|
|||
| Before you begin, install the Snowflake emulator and start the LocalStack container with the following commands: | |||
| Before you begin, pull the Snowflake emulator image (`localstack/snowflake`) and start the LocalStack container: | |||
There was a problem hiding this comment.
do we call the snowflake container still "LocalStack container"? What exactly is LocalStack? 🙃
cc: @whummer
There was a problem hiding this comment.
Any suggestions of an alternative rewording?
There was a problem hiding this comment.
Sure, I guess it is still a "LocalStack container", or more specifically the "LocalStack Snowflake container", but I guess both should be fine here from my PoV. 🤷 (should become clear from the context..)
There was a problem hiding this comment.
Maybe "pull the image for LocalStack for Snowflake"? Might be a bit wordy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.